Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF documentation has redundant code #17092

Closed
willyrk1 opened this issue Dec 29, 2021 · 1 comment · Fixed by #17153
Closed

CSF documentation has redundant code #17092

willyrk1 opened this issue Dec 29, 2021 · 1 comment · Fixed by #17153

Comments

@willyrk1
Copy link

Describe the bug
The CSF API documentation (https://storybook.js.org/docs/react/api/csf) has redundant code blocks:

Now consider the same example, re-written with args:

<Code snippet 1>

At first blush, this might seem no better than the original example. However, if we add the Docs addon and configure the Actions addon appropriately, we can write:

<Code snippet 2>

...except that Code snippet 1 and Code snippet 2 are exactly identical. This doesn't seem like the intention.

@jonniebigodes
Copy link
Contributor

@willyrk1 thanks for bringing this to our attention. This section is indeed a bit redundant and was left in during the updates for 6.4. I've pushed a pull request that fixes this issue.

Have a great day!
Stay safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants