Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descope the addon #318

Closed
14 tasks
skitt opened this issue Mar 14, 2022 · 1 comment
Closed
14 tasks

Descope the addon #318

skitt opened this issue Mar 14, 2022 · 1 comment

Comments

@skitt
Copy link
Member

skitt commented Mar 14, 2022

Epic Description

The Submariner addon currently has wide-ranging privileges. It doesn’t need to be able to access anything outside the namespaces it manages, so this should be reduced. See https://hackmd.io/wVfLKpxtSN-P0n07Kx4J8Q for background.

This might not be appropriate if the addon needs to be able to manage namespaces which aren’t known ahead of time. If so, the justification for its cluster-wide privileges needs to be documented.

Acceptance Criteria

The operator is de-scoped, ideally with no ClusterRole, at minimum with justifications for every permission in its ClusterRole.

See also submariner-io/enhancements#75 for the Submariner operator.

Definition of Done (Checklist)

  • Code complete
  • Relevant metrics added
  • The acceptance criteria met
  • Unit/e2e test added & pass
  • CI jobs pass
  • Deployed using cloud-prepare+subctl
  • Deployed using ACM/OCM addon
  • Deploy using Helm
  • Deployed on supported platforms (for e.g kind, OCP on AWS, OCP on GCP)
  • Run subctl verify, diagnose and gather
  • Uninstall
  • Troubleshooting (gather/diagnose) added
  • Documentation added
  • Release notes added

Work Items

@skitt
Copy link
Member Author

skitt commented Jan 30, 2023

Migrated to https://issues.redhat.com/browse/ACM-3142

@skitt skitt closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant