Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisGit doesn't display content on issues generated by commits #13

Open
MarkW86 opened this issue Sep 27, 2024 · 2 comments · Fixed by #14
Open

VisGit doesn't display content on issues generated by commits #13

MarkW86 opened this issue Sep 27, 2024 · 2 comments · Fixed by #14
Assignees
Labels
dev task🔧 enhancement🏆 New feature or request
Milestone

Comments

@MarkW86
Copy link

MarkW86 commented Sep 27, 2024

Make an issue in VisGit

Make a change to a versioned file

Go to the Git Changes window

enter in a comment for the commit with the last line reading #[X] where [X] is the name of the issue you made.

The above action will associate the commit with the issue on git once synced.

Go to GitHub, verify that the issue now has a comment related the commit you just made.

Go to VisGit and select the issue.

Note that there exists no comment or other content indicating a commit was related to this issue.

Restart Visual Studio

Note that the issue still exists.

I'd like to be able to see this type of update to an issue in VisGit. The commit has a comment directly related to the issue and IMHO constitutes a comment on the issue itself. Even with a refresh button or similar, I don't think VisGit supports displaying this type of change history on an issue. Please add! Many thanks :D

@stigzler stigzler self-assigned this Oct 12, 2024
@stigzler stigzler added this to the 1.0.2 🔃 milestone Oct 12, 2024
@stigzler stigzler added the enhancement🏆 New feature or request label Oct 12, 2024
@stigzler
Copy link
Owner

stigzler commented Oct 12, 2024

Investigated. This doesn't create a comment, but does create an action in the Issue history trail. There's possibly facility in Octokit to get this history, but could be a significant task as involves totally new view or significant modification of the comments view to intersperse historic actions with comment s history (as per GitHub's Issue page overview).

Will play around and determine timescale/do-ability.

@stigzler
Copy link
Owner

stigzler commented Oct 12, 2024

Research

Two relative data types:

Event

TimelineEventInfo - this is preferable - seems to contain all info of above and more.

Relevant oktokit call:

gitHubClient.Issue.Timeline.GetAllForIssue(repositoryId, issueNumber);

Returns ReadOnlyList<TimeLineEventInfo>

Can get type of event from EventInfoState

How to intersperse Comments and Events? Separate tab? (looses value of chronologised actions)

Merge two collections of differing types:
https://learn.microsoft.com/en-us/dotnet/desktop/wpf/data/how-to-implement-a-compositecollection?view=netframeworkdesktop-4.8&redirectedfrom=MSDN

😔 Gonna take some work. Will come back to it.

@stigzler stigzler linked a pull request Oct 12, 2024 that will close this issue
@stigzler stigzler reopened this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev task🔧 enhancement🏆 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants