Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Error click to Load Image if image failed to load #128

Open
aj019 opened this issue Nov 21, 2018 · 3 comments
Open

Hide Error click to Load Image if image failed to load #128

aj019 opened this issue Nov 21, 2018 · 3 comments

Comments

@aj019
Copy link

aj019 commented Nov 21, 2018

  • react-ideal-image version: 0.0.5
  • node version: 10
  • npm (or yarn) version: 6.2.0

Relevant code or config

What you did:

What happened:

screen shot 2018-11-21 at 4 50 17 pm

Reproduction repository:

Problem description:
Error click to Load is ruining the UI

Suggested solution:
OPtion to hide the error message

@stereobooster
Copy link
Owner

But how user will recognise there is an error? I'm not sure I understand full context

@aj019
Copy link
Author

aj019 commented Nov 29, 2018

What i mean is that there should be a way to customize the error message UI. So that the developer can create its own UI for error message.

@stereobooster
Copy link
Owner

stereobooster commented Jan 8, 2019

There is a way to customize it, but there is no tutorial for it, take a look at source code.

Also this is technically possible, current implementation is not the nicest way. #81 should improve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants