Enabling "outputJsonMethods" and "outputPartialMethods" causes builds to fail.

[stevevarga]

Using TS-Proto v1.96.1 with the following config

ts_proto_opt=returnObservable=true,lowerCaseServiceMethods=true,esModuleInterop=true,useOptionals=none,outputJsonMethods=true,outputEncodeMethods=false,outputPartialMethods=true,exportCommonSymbols=true,outputClientImpl=false,oneof=unions

fails to compile, with a large number of issues.

Disabling outputPartialMethods causes fewer issues, but there are several issues that remain with google/protobuf/struct.ts. First, the struct 'fromJSON' method uses 'fromPartial', which is not being generated.

const struct = Struct.fromPartial({});

Second, the wrap method uses syntax that is incompatible with the oneof=unions syntax.

unwrap(message: Value): string | number | boolean | Object | null | Array<any> | undefined {
    if (message?.stringValue !== undefined) {
      return message.stringValue;
    } else if (message?.numberValue !== undefined) {
      return message.numberValue;
    } else if (message?.boolValue !== undefined) {
      return message.boolValue;
    } else if (message?.structValue !== undefined) {
      return message.structValue;
    } else if (message?.listValue !== undefined) {
      return message.listValue;
    } else if (message?.nullValue !== undefined) {
      return null;
    }
    return undefined;
  },

Once outputPartialMethods is enabled, a large number of errors (~593 in my case) appear. They seem to be mostly related to Generics...

Property 'enabled' does not exist on type 'I'
Type 'I' does not satisfy the constraint
Type 'Record' is not generic.
etc.

Here is my TSConfig, for Typescript version 4.5.4

{
  "compilerOptions": {
    "target": "es2018",
    "module": "esnext",
    "moduleResolution": "node",
    "lib": ["es2017", "dom"],
    "declaration": true,
    "outDir": "./lib",
    "strict": true,
    "esModuleInterop": true,
  },
  "include": [
    "./src"
  ],
  "exclude": [
    "node_modules",
    "**/__tests__/*"
  ]
}

Side note: Enabled outputPartialMethods without enabling outputJson seems to be a no-op.

[stevevarga]

Update: This seems to be an issue introduced in 1.96.1.

Rolling back to 1.96.0 fixes compilation issues with the flags.

[stephenh]

Hm, well the the struct.ts / oneof=unions I think is a known issue in #458...

Property 'enabled' does not exist on type 'I'

Can you give more context of the code that causes that error?

You can try the newly added useExactTypes=false option to see if it fixes the generic errors, but if it does I'd love to have a as-minimal-as-possible reproduction *.proto that shows what the issue is, to see if we can try and fix it, instead of just disabling it.

[stevevarga]

Confirmed duplicate of #458.

Can now no longer reproduce the generic issue, it may have been a side effect of #458 or TS config settings. Will open a new issue if it comes up again with a concrete example.