soroban-cli: should return non-zero exit code when can't find data

[leighmcculloch]

What version are you using?

• b1519a4 (rpc and cli)
• stellar/stellar-core@22b9bb3
• stellar/rs-soroban-env@eb5a9ba

What did you do?

❯ soroban contract read --network local --source me --id CAW7SH5JG45U6YLCFB6YD2KVSOZQHMNEJQPN6KDZOCGSXWR72ZIFBBMP --key abc

What did you expect to see?

An error because no contract data or ledger entry is stored with that key.

What did you see instead?

Nothing. No output.

Discussion

It's difficult to compose tools that don't exit with a non-zero code in failure cases.

From a UX point-of-view the user can be left feeling uneasy when a tool returns or outputs nothing.

Tasks

Preview Give feedback

1. soroban-cli: set the exit code to 1 in case of an error soroban-tools#923
   +0
   
2. soroban-cli: return an error once contract read is unable to read any entry. soroban-tools#924
   +0
   

[willemneal]

The exit code issue is also noted here: #774

Currently in the main.rs when doing a run it catches the error and prints it, but doesn't exit with a non-zero code. So this seems like two issues. I agree that there should be a proper error, but I think we should also exit with a non-zero so that scripts and other programs invoking the CLI will know there has been an error.

[tsachiherman]

I agree with @willemneal here. The fact that the empty group isn't being reported as an error in this particular case is an issue - but not the same issue not setting the exit code to 1. Let's tackle these separately ?