-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for a modern SDK #792
Comments
I'm fully behind this request. Webpack 5 support is table stakes, EventSource seems like extra complexity without any benefits, given how promises and cursors can get all the same data. |
@Shaptic Awesome work! Great to see that you are modernizing JS packages. In addition to the existing changes it would be nice to drop some dependencies:
Other suggestions:
I can help with some of this work. Removing redundant dependencies will result in a dramatic bundle size decrease for most Stellar-related webapps, not to mention better performance and lighter memory footprint. |
aaand I'm back 🏖️ Thank you for the comprehensive list of suggestions, @orbitlens; your expertise and input here is deeply appreciated 🙏 Please feel free to make contributions as you see fit, though there's no pressure: I will slowly work my way through this list as well! |
MIGRATED from js-stellar-base/issues/532
After digging into the SDK and the API I've noticed several issues and some true roadblocks for front-end web applications.
The SDK currently uses Webpack 4.33.0. This is a roadblock for some modern apps and frameworks
(WP 5 environments)
In a Webpack 5 world EventSource and its deps must be polyfilled. This is a compounded issue because the SDK's version 1.0.7 (> 4 years old) likely requires polys that match its own dependencies' versions.
TypeScript 3.4.5 is outdated and an optimized TS developer experience is healthy, safer and easier for everyone.
To get started I spent an hour debugging
rt.times(...).greaterThan is not a function
which was fixed by falling back to"bignumber.js": "8.0.1"
from9.0.2
. Since we need BigNumber it would be recommended that the SDK team drives compatibility and guidance here.confirm the SDK is exporting code in a recent ECMA standard.
The text was updated successfully, but these errors were encountered: