You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on #3694 I noticed that CaptiveCoreBackend.isClosed is confused with CaptiveCoreBackend.isPrepared. When CaptiveCoreBackend is closed by Close() call it can't be reused because internal ctx is cancelled and ledgerHashStore is closed however we often check isClosed() and the print an error saying: session is closed, call PrepareRange first.
What did you see instead?
I think what we should do is perform two checks:
Check isClosed() - then prevent from using the CaptiveCoreBackend - PrepareRange and GetLedger should error.
Check isPrepared() - if it's not return an error asking to prepare the range again.
The text was updated successfully, but these errors were encountered:
What version are you using?
2.4.1
What did you do?
While working on #3694 I noticed that
CaptiveCoreBackend.isClosed
is confused withCaptiveCoreBackend.isPrepared
. WhenCaptiveCoreBackend
is closed byClose()
call it can't be reused because internalctx
is cancelled andledgerHashStore
is closed however we often checkisClosed()
and the print an error saying:session is closed, call PrepareRange first
.What did you see instead?
I think what we should do is perform two checks:
isClosed()
- then prevent from using theCaptiveCoreBackend
-PrepareRange
andGetLedger
should error.isPrepared()
- if it's not return an error asking to prepare the range again.The text was updated successfully, but these errors were encountered: