Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept parameters via command line #89

Closed
stefanjudis opened this issue May 20, 2014 · 6 comments
Closed

Accept parameters via command line #89

stefanjudis opened this issue May 20, 2014 · 6 comments
Assignees
Labels
Milestone

Comments

@stefanjudis
Copy link
Owner

By the way, our use case requires passing in parameters via the command line i.e. grunt phantomas --film-strip=true - would you be interested in a PR that allowed that?

@stefanjudis
Copy link
Owner Author

Hmm... I'm not sure about that.

Why not setting it via options in grunt config?
Can you maybe explain the reasons a bit more in detail? :)

And wouldn't it be a bit inconsistent to pass only phantomas option via cli?
I mean grunt phantomas --film-strip=true is cleary targeting a phantomas option.

To not mix it up grunt phantomas --indexPath=foo shouldn't be possible. And only making phantomas options available doesn't feel correct.

@stefanjudis stefanjudis self-assigned this May 20, 2014
@davidlinse
Copy link

One case i could image this would be helpful is when you want to test a CI setup.
Instead of changing and pushing the config this would allow to test a job in a _cli_ish way.
But i don't know what other options would be included.. so..
My two cents.. ;)

~david

@stefanjudis stefanjudis added this to the v0.7.2 milestone May 21, 2014
@stefanjudis
Copy link
Owner Author

Hmm...
But shouldn't that be handled exactly via config?
I mean isn't that kind of going in the wrong direction. I'm planning to encapsulate this little tool from grunt soon, which means, that it will be a cli tool (or even a real application) - but for now in grunt task area I'm not sure, if it should cover that.

And don't get me wrong, I'm totally open to that - I'm just not sure, if it's a good idea. :bowtie:

@ionutzp
Copy link
Contributor

ionutzp commented Jun 5, 2014

@davidlinse You can wrap the phantomas task inside another task on your CI which can take command line paramters

@davidlinse
Copy link

You can wrap the phantomas task inside another task on your CI which can take command line paramters

I know, thanks.. Just wanted to contribute a possible use case.

@stefanjudis
Copy link
Owner Author

Okay. I'm closing this one. Feel free to reopen if needed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants