Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phantomas runs are not synchronous #147

Closed
robwalch opened this issue Dec 16, 2014 · 2 comments
Closed

Phantomas runs are not synchronous #147

robwalch opened this issue Dec 16, 2014 · 2 comments
Assignees
Milestone

Comments

@robwalch
Copy link

When running my grunt-phantomas test with the --debug flag, I noticed the tests are not executed synchronously. Instead it looks like they're run all at once. iTerm and the activity monitor shows that all instances of phantomjs are spun up at once for the number of runs requested.

This means instead getting a better mean and average by doing more runs, I'm actually impacting the performance and timings of all runs by specifying a large number of runs. 🙅

PHANTOMAS EXECUTION(S) STARTED.
Executing phantomas ( 5 times ) with following parameters:
{"timeout":10,"allow-domain":"content.jwplatform.com,p.jwpcdn.com,i.n.jwpltx.com"}
[D] server GET /test/performance/setup-responsive-autostart.html 200 1882 - 13 ms
[D] server GET /test/performance/setup-responsive-autostart.html 200 1882 - 9 ms
[D] server GET /test/performance/setup-responsive-autostart.html 200 1882 - 1 ms
[D] server GET /test/performance/phantomas/test-module.js 200 10260 - 2 ms
[D] server GET /test/performance/phantomas/test-module.js 200 10260 - 4 ms
[D] server GET /bin-release/test.js 200 72325 - 6 ms
[D] server GET /test/assets/providers/html5.provider.timer.js 200 3316 - 4 ms
[D] server GET /bin-release/test.js 200 72325 - 4 ms
[D] server GET /test/assets/providers/html5.provider.timer.js 200 3316 - 2 ms
[D] server GET /test/performance/phantomas/test-module.js 200 10260 - 1 ms
[D] server GET /bin-release/test.js 200 72325 - 2 ms
[D] server GET /test/assets/providers/html5.provider.timer.js 200 3316 - 1 ms
[D] server GET /bin-release/test.html5.js 200 172412 - 3 ms
[D] server GET /bin-release/test.html5.js 200 172412 - 5 ms
[D] server GET /bin-release/test.html5.js 200 172412 - 3 ms
[D] server GET /test/performance/setup-responsive-autostart.html 200 1882 - 1 ms
[D] server GET /test/performance/phantomas/test-module.js 200 10260 - 4 ms
[D] server GET /test/assets/providers/html5.provider.timer.js 200 3316 - 3 ms
[D] server GET /bin-release/test.js 200 72325 - 4 ms
[D] server GET /test/performance/setup-responsive-autostart.html 200 1882 - 3 ms
[D] server GET /test/performance/phantomas/test-module.js 200 10260 - 4 ms
[D] server GET /test/assets/providers/html5.provider.timer.js 200 3316 - 5 ms
[D] server GET /bin-release/test.js 200 72325 - 5 ms
[D] server GET /bin-release/test.html5.js 200 172412 - 1 ms
[D] server GET /bin-release/test.html5.js 200 172412 - 1 ms
>> 5 Phantomas execution(s) done -> checking results:
>> Phantomas execution successful.
>> Phantomas execution successful.
>> Phantomas execution successful.
>> Phantomas execution successful.
>> Phantomas execution successful.
@stefanjudis
Copy link
Owner

Yeah - totally true. They're run at the same time at the moment.

Should be one after another. Thanks for pointing that out. :)

@stefanjudis
Copy link
Owner

fixed with #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants