We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug skipValidate doesnt applied in estimateFeeBulk method
skipValidate
estimateFeeBulk
In https://github.com/starknet-io/starknet.js/blob/v6.6.0/src/account/default.ts#L260
we may fix the code in
public async estimateFeeBulk( invocations: Invocations, details: UniversalDetails = {} ): Promise<EstimateFeeBulk> { const { nonce, blockIdentifier, version, skipValidate } = details; const accountInvocations = await this.accountInvocationsFactory(invocations, { ...v3Details(details), versions: [ ETransactionVersion.F1, // non-sierra toTransactionVersion( this.getPreferredVersion(ETransactionVersion.F2, ETransactionVersion.F3), version ), // sierra ], nonce, blockIdentifier, skipValidate, }); return super.getEstimateFeeBulk(accountInvocations, { blockIdentifier, skipValidate: skipValidate, }); }
To Reproduce trigger estimateFeeBulk
Expected behavior RPC request should include signature
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Describe the bug
skipValidate
doesnt applied inestimateFeeBulk
methodIn https://github.com/starknet-io/starknet.js/blob/v6.6.0/src/account/default.ts#L260
we may fix the code in
To Reproduce
trigger estimateFeeBulk
Expected behavior
RPC request should include signature
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: