Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipValidate doesnt applied in estimateFeeBulk method #1029

Closed
stanleyyconsensys opened this issue Mar 21, 2024 · 0 comments · Fixed by #1037
Closed

skipValidate doesnt applied in estimateFeeBulk method #1029

stanleyyconsensys opened this issue Mar 21, 2024 · 0 comments · Fixed by #1037
Labels
Type: bug Something isn't working

Comments

@stanleyyconsensys
Copy link

Describe the bug
skipValidate doesnt applied in estimateFeeBulk method

In https://github.com/starknet-io/starknet.js/blob/v6.6.0/src/account/default.ts#L260

we may fix the code in

 public async estimateFeeBulk(
    invocations: Invocations,
    details: UniversalDetails = {}
  ): Promise<EstimateFeeBulk> {
    const { nonce, blockIdentifier, version, skipValidate } = details;
    const accountInvocations = await this.accountInvocationsFactory(invocations, {
      ...v3Details(details),
      versions: [
        ETransactionVersion.F1, // non-sierra
        toTransactionVersion(
          this.getPreferredVersion(ETransactionVersion.F2, ETransactionVersion.F3),
          version
        ), // sierra
      ],
      nonce,
      blockIdentifier,
      skipValidate,
    });

    return super.getEstimateFeeBulk(accountInvocations, {
      blockIdentifier,
      skipValidate: skipValidate,
    });
  }

To Reproduce
trigger estimateFeeBulk

Expected behavior
RPC request should include signature

Desktop (please complete the following information):

  • Node version: 18.18.2
  • Starknet.js version: 6.6.0
  • Network [devnet, testnet]: testnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant