From 6907d2dbc341bbf0608c3b37c91489346c81d97e Mon Sep 17 00:00:00 2001 From: LilShah <34099012+LilShah@users.noreply.github.com> Date: Wed, 12 Apr 2023 14:20:48 +0500 Subject: [PATCH 1/3] spellings --- api/v1alpha1/endpointmonitor_types.go | 2 +- .../endpointmonitor.stakater.com_endpointmonitors.yaml | 2 +- .../endpointmonitor.stakater.com_endpointmonitors.yaml | 2 +- .../endpointmonitor.stakater.com_endpointmonitors.yaml | 2 +- docs/uptimerobot-configuration.md | 8 ++++---- pkg/monitors/pingdom/pingdom-monitor.go | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/api/v1alpha1/endpointmonitor_types.go b/api/v1alpha1/endpointmonitor_types.go index 31e686a4..a819a96b 100644 --- a/api/v1alpha1/endpointmonitor_types.go +++ b/api/v1alpha1/endpointmonitor_types.go @@ -195,7 +195,7 @@ type StatusCakeConfig struct { // +optional NodeLocations string `json:"nodeLocations,omitempty"` - // Comma seperated list of HTTP codes to trigger error on + // Comma separated list of HTTP codes to trigger error on // +optional StatusCodes string `json:"statusCodes,omitempty"` diff --git a/bundle/manifests/endpointmonitor.stakater.com_endpointmonitors.yaml b/bundle/manifests/endpointmonitor.stakater.com_endpointmonitors.yaml index 73d200e1..ac7f6781 100644 --- a/bundle/manifests/endpointmonitor.stakater.com_endpointmonitors.yaml +++ b/bundle/manifests/endpointmonitor.stakater.com_endpointmonitors.yaml @@ -161,7 +161,7 @@ spec: description: Enable Real Browser type: boolean statusCodes: - description: Comma seperated list of HTTP codes to trigger error + description: Comma separated list of HTTP codes to trigger error on type: string testTags: diff --git a/charts/ingressmonitorcontroller/crds/endpointmonitor.stakater.com_endpointmonitors.yaml b/charts/ingressmonitorcontroller/crds/endpointmonitor.stakater.com_endpointmonitors.yaml index 6cfb5cf3..344a521c 100644 --- a/charts/ingressmonitorcontroller/crds/endpointmonitor.stakater.com_endpointmonitors.yaml +++ b/charts/ingressmonitorcontroller/crds/endpointmonitor.stakater.com_endpointmonitors.yaml @@ -162,7 +162,7 @@ spec: description: Enable Real Browser type: boolean statusCodes: - description: Comma seperated list of HTTP codes to trigger error + description: Comma separated list of HTTP codes to trigger error on type: string testTags: diff --git a/config/crd/bases/endpointmonitor.stakater.com_endpointmonitors.yaml b/config/crd/bases/endpointmonitor.stakater.com_endpointmonitors.yaml index 6cfb5cf3..344a521c 100644 --- a/config/crd/bases/endpointmonitor.stakater.com_endpointmonitors.yaml +++ b/config/crd/bases/endpointmonitor.stakater.com_endpointmonitors.yaml @@ -162,7 +162,7 @@ spec: description: Enable Real Browser type: boolean statusCodes: - description: Comma seperated list of HTTP codes to trigger error + description: Comma separated list of HTTP codes to trigger error on type: string testTags: diff --git a/docs/uptimerobot-configuration.md b/docs/uptimerobot-configuration.md index 478b3120..d1bff5b3 100644 --- a/docs/uptimerobot-configuration.md +++ b/docs/uptimerobot-configuration.md @@ -29,7 +29,7 @@ You will get a response similar to what is shown below ] ``` -Copy values of `id` field of your alert contacts which you want to use for Ingress Monitor Controller and append `_0_0` to them and seperate them by `-`. You will now have a string similar to `12345_0_0-23564_0_0`. This is basically the value you will need to specify in Ingress Monitor Controller's ConfigMap as `alertContacts`. +Copy values of `id` field of your alert contacts which you want to use for Ingress Monitor Controller and append `_0_0` to them and separate them by `-`. You will now have a string similar to `12345_0_0-23564_0_0`. This is basically the value you will need to specify in Ingress Monitor Controller's ConfigMap as `alertContacts`. ## Configuration @@ -82,7 +82,7 @@ You will get a response similar to what is shown below } ``` -Copy values of `id` field of your public status page which you want to use for Ingress Monitor Controller into the relevant EndpointMonitor CR. +Copy values of `id` field of your public status page which you want to use for Ingress Monitor Controller into the relevant EndpointMonitor CR. ### Fetching maintenance windows from UpTime Robot @@ -121,7 +121,7 @@ You will get a response similar to what is shown below Copy values of `id` field of the maintenance windows which you want to use for Ingress Monitor Controller and separate them by `-`. You will now have a string similar to `12345-23564`. This is basically the value you will need to specify in the maintenance-windows EndpointMonitor CR. -## Example: +## Example: ```yaml apiVersion: endpointmonitor.stakater.com/v1alpha1 @@ -139,5 +139,5 @@ spec: keywordExists: true keywordValue: 404 statusPages: "status-page" - + ``` diff --git a/pkg/monitors/pingdom/pingdom-monitor.go b/pkg/monitors/pingdom/pingdom-monitor.go index 11d62bc2..c8b54184 100644 --- a/pkg/monitors/pingdom/pingdom-monitor.go +++ b/pkg/monitors/pingdom/pingdom-monitor.go @@ -248,7 +248,7 @@ func (service *PingdomMonitorService) addConfigToHttpCheck(httpCheck *pingdom.Ht log.Info("Should contain detected. Setting Should Contain string: " + providerConfig.ShouldContain) } - // Tags should be a single word or multiple comma-seperated words + // Tags should be a single word or multiple comma-separated words if providerConfig != nil && len(providerConfig.Tags) > 0 { if !strings.Contains(providerConfig.Tags, " ") { httpCheck.Tags = providerConfig.Tags From c9c8d0acf007a1812531cf5ba67414a36f70c3c5 Mon Sep 17 00:00:00 2001 From: LilShah <34099012+LilShah@users.noreply.github.com> Date: Wed, 12 Apr 2023 14:21:12 +0500 Subject: [PATCH 2/3] remove deprecated arg --- charts/ingressmonitorcontroller/templates/deployment.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/charts/ingressmonitorcontroller/templates/deployment.yaml b/charts/ingressmonitorcontroller/templates/deployment.yaml index 576a1d26..edad69c4 100644 --- a/charts/ingressmonitorcontroller/templates/deployment.yaml +++ b/charts/ingressmonitorcontroller/templates/deployment.yaml @@ -32,7 +32,6 @@ spec: - args: - --secure-listen-address=0.0.0.0:8443 - --upstream=http://127.0.0.1:8080/ - - --logtostderr=true - --v=0 image: {{ printf "%s:%s" .image.repository .image.tag | default "gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0" | quote }} imagePullPolicy: {{ .image.pullPolicy | quote }} From 264537755d835d6b33382d7b266eeeda7298a057 Mon Sep 17 00:00:00 2001 From: LilShah <34099012+LilShah@users.noreply.github.com> Date: Wed, 12 Apr 2023 14:21:33 +0500 Subject: [PATCH 3/3] add stale issues workflow --- .github/workflows/issues.yaml | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .github/workflows/issues.yaml diff --git a/.github/workflows/issues.yaml b/.github/workflows/issues.yaml new file mode 100644 index 00000000..91a2337c --- /dev/null +++ b/.github/workflows/issues.yaml @@ -0,0 +1,22 @@ +name: Close inactive issues +on: + schedule: + - cron: "30 1 * * *" + +jobs: + close-issues: + runs-on: ubuntu-latest + permissions: + issues: write + pull-requests: write + steps: + - uses: actions/stale@v5 + with: + days-before-issue-stale: 60 + days-before-issue-close: 30 + stale-issue-label: "stale" + stale-issue-message: "This issue is stale because it has been open for 60 days with no activity." + close-issue-message: "This issue was closed because it has been inactive for 30 days since being marked as stale." + days-before-pr-stale: -1 + days-before-pr-close: -1 + repo-token: ${{ secrets.GITHUB_TOKEN }}