-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signer should control which stackers can delegate to the signer #4247
Comments
Stacking transactions would require a signature over the stacking function's arguments from the signing private key. The stacking function would authenticate the signature in order to validate the signing public key. |
There's two possible ways to handle this:
The advantage of (1) is that it simplifies the PoX contract. The advantage of (2) is that it doesn't require the signer to actually use their signing key before the stacking cycle starts. |
Another advantage of (1) is that you can change your key in the same transaction as you stack, so you don't have to worry about mempool congestion preventing you from rotating your signing key. |
@saralab to assign me (hoping I can get added to the repo/org so I can add myself) |
igotchu |
Currently, Fast pool accepts any stacker as pool member. It is a self-service pool. |
@friedger yes, but you should be able to build tooling to automatically generate signatures for anyone who wants to join. |
Per discussion during one of the engineering calls: does it make sense to an allow/deny mode for pools that are fine accepting anyone? Then if it is set to allow, no signatures are required. To me it really feels like an undue and risky burden to require pool operators to run a service exposed to the internet that produces these signatures. I also want to challenge the framing of this problem. It is pretty easy for a blocked stacker to create a new address to stack from. How can a signer properly vet this in the end? I feel like forcing these signatures will bring little benefit but a lot of extra infrastructure cost. Tagging the PR to create a reference to this issue: #4277 |
@MarvinJanssen, now that the signer key is only provided at |
That's true. It would only remain for solo stacking which is a specific use-case. Nonetheless, the problem would remain there. |
How does this work for solo stackers stacking for 12 cycles? Which key do they need to use as the signing key changes every cycle? |
@friedger I don't think you need to rotate your signer key every cycle anymore - it only changes with |
If half of the stackers are solo stackers for 12 cycles and the other for 6. Then the first 6 cycles the aggregate public key is the same. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Is your feature request related to a problem? Please describe.
For legal or other reasons, signers might not want to accept signing duties for some stackers who want to delegate signing to them.
Describe the solution you'd like
Describe alternatives you've considered
Additional context
@MarvinJanssen mentioned the issue first I think
The text was updated successfully, but these errors were encountered: