-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings from SDK-created embeds don't propagate when opening in new window #858
Comments
@graynorton great catch- I'm sorry about this! Should be a simple fix on our end, will def have it knocked out by EOD tmrw. Also- I'm going to release a new version of our SDK tomorrow that enables the new polymer template 😄 Will circle back here once that's live as well. Lmk if there's anything else we can do to help y'all! |
Awesome – thanks, @EricSimons! |
@graynorton this is now fixed on prod! Just tested the lit-element docs too and seems to work correctly 👍 Also, I just pushed a new version of the sdk (1.3.0) that enables Polymer support w/ no transpilation- just use |
Launch Code Editor
buttonsReload mechanism
is set toPage reload
Edit on StackBlitz
in the lower right corner of the embed=>
Reload mechanism
is set toHot reload
It's important for our use case that the settings we specify using the SDK propagate to the full-window experience. Since we're using web components and can only register a custom element once, hot reload causes runtime errors in our projects.
The text was updated successfully, but these errors were encountered: