Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any Github Support #167

Closed
michaellee8 opened this issue Oct 11, 2017 · 6 comments
Closed

Any Github Support #167

michaellee8 opened this issue Oct 11, 2017 · 6 comments

Comments

@michaellee8
Copy link

If could be wonderful if we can perform github push and pull and even some command lines like we did generally. Currently without github support make this app just a enhanced jsfiddle, but with Github support it is full-fledged

@SindreSvendby
Copy link

Is there anyway I can help on this? This is the missing feature for us to try to use this in our workflow!

If i created a POC repo where I connect to github, retrieve the files and put it into the monaco-editor would that help? I'm not sure on architecture you have, so please advice on what kind of module I can create that would help you implement this feature!

@maks
Copy link

maks commented Oct 28, 2017

There is a long and illustrious (ignominious?) history of getting an in-browser git client working Note that talk was Mar 2014!
The most promising thing since then that I am aware of is libgit2 port to JS via emscripten BUT this can't work as Github for some reason continues to refuse to enable CORS, so you need to have a proxy to get this to work in browser.

@SindreSvendby
Copy link

@maks now you are talking about a general git solution ?

You can use the github API to do changes to a repo: https://developer.github.com/v3/repos/contents/

@maks
Copy link

maks commented Nov 2, 2017

@SindreSvendby yes actual git protocol.
I do know about the GH API v3 but that is going to generate a HUGE amount of network requests for anything beyond a trivially small repo. Still that is about the only thing that will actually work atm.
I just don't understand GH's reluctance to enable CORS for git protocol https access.

@titombo
Copy link

titombo commented Jul 20, 2018

Hi @SindreSvendby and @maks did it worked for you? I am trying to achieve something similar like in here: https://stackoverflow.com/questions/51389437/send-and-get-data-from-code-editor-like-plunker-embedded

Could be on stackblitz as well instead of another tool, in this case instead of POST to our servers it would POST to github and our servers would download from there.

@kc0tlh
Copy link
Collaborator

kc0tlh commented Aug 23, 2023

@michaellee8, @SindreSvendby, @maks, and @titombo: this issue is now resolved in our new VS Code editor! Full writeup in Github issue #2473

@kc0tlh kc0tlh closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants