Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing previous link when offset>0 but limit > number_matched #338

Open
vincentsarago opened this issue Jan 10, 2025 · 0 comments
Open

Comments

@vincentsarago
Copy link
Member

In

IF _limit <= number_matched AND number_matched > 0 THEN --need to have paging links

we check if we have needs for previous/next links. I believe there is a case that is missing (ref: https://github.com/stac-utils/stac-fastapi-pgstac/pull/155/files#r1910644543) when you can have less than limit number of collection (e.g n_collections=4 and limit=10) but user may have provided offset=.

Anytime there is an offset>0 I feel we should have a previous link

cc @bitner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant