Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] small ui overhaul suggestions w/ concept drawings #872

Closed
3 tasks done
KyleKlus opened this issue Feb 8, 2024 Discussed in #870 · 4 comments
Closed
3 tasks done

[FEAT] small ui overhaul suggestions w/ concept drawings #872

KyleKlus opened this issue Feb 8, 2024 Discussed in #870 · 4 comments

Comments

@KyleKlus
Copy link
Contributor

KyleKlus commented Feb 8, 2024

Hi there,

I have some ideas for a small ui overhaul on "obsidian spaced repetition" and I have made some concept drawings. So, I wanted to share these here and see if anybody has some remarks (especially @st3v3nmw, @ronzulu). I would be happy to implement those ideas myself in a PR draft.

Proposal for code changes

  • Refactoring FlashcardModal into several views.
  • Refactoring keyboard listener
  • Implementing ui changes

Concept drawings

left -> mockup, right -> comments

image

image

image

image

@KyleKlus KyleKlus changed the title [Feat] small ui overhaul suggestions w/ concept drawings [FEAT] small ui overhaul suggestions w/ concept drawings Feb 8, 2024
@ronzulu
Copy link
Collaborator

ronzulu commented Feb 12, 2024

Hi again

I like nearly all of your ideas, but unsure of a couple.

(2) Are you planning to include the full word or just the first letter? I'm just concerned about non-English translations where potentially the first letter isn't unique for new/due/total

(3) nice suggestion, but the disadvantage is that it would cause (some, although temporary) confusion for existing users. Also would be confusing if a user was to lookup up existing documentation or posts, and the order was opposite to the software.

I'm sure you are much more visually aware than most 😄 It never crossed my mind that the colours on this page are in a different order to the ones on the buttons on the card review view!

image

@KyleKlus
Copy link
Contributor Author

(2) I came across this issue too, so I included the whole word, instead of just the first letter. I think it looks worse than just having one letter or nothing in front of it, but I was always confused, which color means what, so I kept it, as it improves the onboarding experience for new user a lot.
This is how it now looks:
image

(3) I thought of that too, so I didn't switch the colors, but I switched the positions of the numbers around, so that the people can still rely on the color they learned, but the order is different

@KyleKlus
Copy link
Contributor Author

New card view

image

New edit view

image

@st3v3nmw
Copy link
Owner

I think we can close this now

@github-project-automation github-project-automation bot moved this to Done (available in next release) in Roadmap Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped!
Development

No branches or pull requests

3 participants