Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ssz tests #258

Open
GalRogozinski opened this issue May 23, 2023 · 2 comments
Open

Fix ssz tests #258

GalRogozinski opened this issue May 23, 2023 · 2 comments
Labels
refactor

Comments

@GalRogozinski
Copy link
Contributor

GalRogozinski commented May 23, 2023 •
edited
Loading

Description

withdrawals_marahsling_validation compares two hashroots of 2 withdrawal objects.
It is obscure in the test but both withdrawals were derived from the same json object... so the test checks nothing.

See:
#257 (comment)_
@GalRogozinski GalRogozinski mentioned this issue May 23, 2023
Merged
@GalRogozinski
Copy link
Contributor Author

duplicate of #245

@GalRogozinski
Copy link
Contributor Author

I am reopening because it is actually a bit different than #245

@GalRogozinski GalRogozinski reopened this May 24, 2023
@GalRogozinski GalRogozinski changed the title Fix or delete ssz_tests Fix ssz tests May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GalRogozinski