From 9c454544ad2c5a2e8e16b19035b270738b3b0e87 Mon Sep 17 00:00:00 2001 From: Stijn Strickx Date: Mon, 6 Nov 2017 23:48:32 +0100 Subject: [PATCH] Fixes #107 No proper null check on some fields --- .../quotes/query1v7/StockQuotesQuery1V7Request.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/main/java/yahoofinance/quotes/query1v7/StockQuotesQuery1V7Request.java b/src/main/java/yahoofinance/quotes/query1v7/StockQuotesQuery1V7Request.java index f277aa5..1246b48 100644 --- a/src/main/java/yahoofinance/quotes/query1v7/StockQuotesQuery1V7Request.java +++ b/src/main/java/yahoofinance/quotes/query1v7/StockQuotesQuery1V7Request.java @@ -27,9 +27,14 @@ protected Stock parseJson(JsonNode node) { String symbol = node.get("symbol").asText(); Stock stock = new Stock(symbol); - stock.setName(node.get("longName").asText()); - stock.setCurrency(node.get("currency").asText()); - stock.setStockExchange(node.get("fullExchangeName").asText()); + if(node.has("longName")) { + stock.setName(node.get("longName").asText()); + } else { + stock.setName(getStringValue(node, "shortName")); + } + + stock.setCurrency(getStringValue(node, "currency")); + stock.setStockExchange(getStringValue(node, "fullExchangeName")); stock.setQuote(this.getQuote(node)); stock.setStats(this.getStats(node));