PDA Slots (PDA-slots branch)

[BlueNexus]

Alright, so PDA slots work fine in every way, except you can't actually put PDA's in them. I've traced the issue back to the items.dm file in objects, under mob_can_equip. Help would be hugely appreciated.

[DJPantheris]

Did you attempt to set the PDA slot size designation to hold pocketable items and then set the item specific designation to the the definition of the PDA?

[Ryan784]

As I've been looking into this, I have managed to pinpoint exactly where in the code the PDA is getting stopped from being equipped:

Line 239:
//First check if the item can be equipped to the desired slot.
if("[slot]" in slot_flags_enumeration)
var/req_flags = slot_flags_enumeration["[slot]"]
if(!(req_flags & slot_flags))
return 0

So, I editted the code so it would print out messages to help with debugging:

//First check if the item can be equipped to the desired slot.
if("[slot]" in slot_flags_enumeration)
    H << "<span class='warning'>if('[slot]' in [slot_flags_enumeration]).</span>"
    var/req_flags = slot_flags_enumeration["[slot]"]
    H << "<span class='warning'>Var/req_flags = slot_flags_enumeration('[slot]').</span>"
    H << "<span class='warning'>Var/req_flags == [req_flags].</span>"
    //H << "<span class='warning'>Slot [slot] != Req_flags; Req_flags: [req_flags]; slot_flags: [slot_flags].</span>"
    if(!(req_flags & slot_flags))
        H << "<span class='warning'>if(![req_flags] & [slot_flags]).</span>"
        H << "<span class='warning'>return 0.</span>"
        H << "<span class='warning'>[req_flags] & [slot_flags] not met. More specifically, if(![req_flags & slot_flags]).</span>"
        return 0

So with that in and attempting to equip a PDA, you get this result:

if('23' in /list).
Var/req_flags = slot_flags_enumeration('23').
Var/req_flags == 65536.
if(!65536 & 768).
return 0.
65536 & 768 not met. More specifically, if(!0).
You are unable to equip PDA-Eddie Prevatt (Detective) in slot 23.

So, for whatever reason, the PDA is returning a bitmask of 768, which is the result of both the slot_id and slot_belt flags - so essentially it is ignoring the slot_pda flag.

[Ryan784]

Further tinkering with it, found the problem: the total bitmask can't be greater than 65535, so essentially the bitmask needs to be less than or equal to 16th bit (32768) for the SLOT_PDA, in setup.

[Lorwp]

Being Fixed in #79