Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom LFS integration in RTD build broke #23

Closed
dokempf opened this issue Jul 2, 2021 · 1 comment
Closed

Custom LFS integration in RTD build broke #23

dokempf opened this issue Jul 2, 2021 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@dokempf
Copy link
Member

dokempf commented Jul 2, 2021

We do this trickery to work around the fact that RTD does not support Git LFS: https://github.com/ssciwr/adaptivefiltering/blob/main/doc/source/conf.py#L67

Unfortunately this broke last week, but it also did for others: readthedocs/readthedocs.org#8288
The logs suggest that the LFS checkout is successful, but the changes are overriden later on.
@dokempf dokempf added bug Something isn't working documentation Improvements or additions to documentation labels Jul 2, 2021
This was referenced Jul 2, 2021
Closed
Merged
@dokempf
Copy link
Member Author

dokempf commented Jul 5, 2021

Fixed by implementing a workaround and packaging it into an extension.

@dokempf dokempf closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove LFS to work around RTD build issues ssciwr/afwizard
1 participant
@dokempf