Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

analyzer: Check rule that try merge compatible indexes. #213

Closed
ajnavarro opened this issue Jun 13, 2018 · 5 comments
Closed

analyzer: Check rule that try merge compatible indexes. #213

ajnavarro opened this issue Jun 13, 2018 · 5 comments
Assignees
@erizocosmico
Labels
enhancement New feature or request
Milestone
Index-2

Comments

@ajnavarro
Copy link
Contributor

ajnavarro commented Jun 13, 2018 •
edited
Loading

We need to check the actual rule that makes use of SetOperations and Mergeable Lookup interfaces.

This rule will be in charge of checking all the obtained indexes and try to merge them all together.

If not all the indexes are mergeable, use the most merged Index Lookup and discard the rest.
@ajnavarro ajnavarro added the enhancement New feature or request label Jun 13, 2018
@ajnavarro ajnavarro added this to the Index-2 milestone Jun 13, 2018
@erizocosmico
Copy link
Contributor

That's already implemented https://github.com/src-d/go-mysql-server/blob/master/sql/analyzer/rules.go#L1099-L1258

@ajnavarro ajnavarro changed the title analyzer: Create a rule to try to merge compatible indexes. analyzer: Check rule that to try to merge compatible indexes. Jun 13, 2018
@ajnavarro
Copy link
Contributor Author

Changed the title to test that implementation with all the actual new development.

@ajnavarro ajnavarro changed the title analyzer: Check rule that to try to merge compatible indexes. analyzer: Check rule that to try merge compatible indexes. Jun 13, 2018
@ajnavarro ajnavarro changed the title analyzer: Check rule that to try merge compatible indexes. analyzer: Check rule that try merge compatible indexes. Jun 13, 2018
@erizocosmico
Copy link
Contributor

Depends on #212

@erizocosmico
Copy link
Contributor

Blocked until #212 is done

@erizocosmico erizocosmico added the blocked Some other issue is blocking this label Jul 6, 2018
@erizocosmico
Copy link
Contributor

This is not blocked anymore

@erizocosmico erizocosmico removed the blocked Some other issue is blocking this label Jul 17, 2018
@erizocosmico erizocosmico self-assigned this Jul 18, 2018
@erizocosmico erizocosmico mentioned this issue Jul 18, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@erizocosmico erizocosmico

Labels
enhancement New feature or request
Projects
None yet
Milestone
Index-2
Development

No branches or pull requests
2 participants
@ajnavarro @erizocosmico