Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for os_signpost #1083

Closed
AquaGeek opened this issue Apr 7, 2020 · 1 comment · Fixed by #1134
Closed

Add support for os_signpost #1083

AquaGeek opened this issue Apr 7, 2020 · 1 comment · Fixed by #1134
Assignees
@AquaGeek
Labels
debugging enhancement New feature or request swift Affects the Swift library.

Comments

@AquaGeek
Copy link
Contributor

AquaGeek commented Apr 7, 2020

The os_signpost APIs introduced in iOS 12 allow us to provide more visibility into the internals of the library. I built a prototype of this (see stromberg/os_signpost branch), but it needs to be cleaned up before getting reviewed.
@AquaGeek AquaGeek added the swift Affects the Swift library. label Apr 7, 2020
@AquaGeek AquaGeek self-assigned this Apr 7, 2020
@AquaGeek
Copy link
Contributor Author

AquaGeek commented May 4, 2020

Ugh. Creating a wrapper for os_signpost is problematic due to the variadic arguments and the lack of a function that takes va_list: https://stackoverflow.com/a/50942917 🤦

@AquaGeek AquaGeek added debugging enhancement New feature or request labels May 4, 2020
@AquaGeek AquaGeek mentioned this issue May 5, 2020
Merged
@JustinDSN JustinDSN mentioned this issue May 21, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AquaGeek AquaGeek

Labels
debugging enhancement New feature or request swift Affects the Swift library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add os_signpost logs for render() and Workflow and Worker lifecycle square/workflow
1 participant
@AquaGeek