Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all color-related options into Preferences -> Color scheme #820

Closed
spyder-bot opened this issue Feb 17, 2015 · 6 comments
Closed

Move all color-related options into Preferences -> Color scheme #820

spyder-bot opened this issue Feb 17, 2015 · 6 comments

Comments

@spyder-bot
Copy link
Collaborator

From techtonik@gmail.com on 2011-11-01T02:17:32Z

Spyder Version: 2.1.0
Python Version: 2.7.2
Qt Version: 4.7.4, PySide 1.0.7 on Linux

What steps will reproduce the problem?

To change backround color for Spyder and all its plugins, you need to click through all preference pages to find out which scheme is active.

It will be much more ituitive if all scheme selection and scheme color options were concentrated on the same page. This will require some 'extension point' mechanizm which allows plugins to plug into scheme selection page. Any ideas how to implement this?

Original issue: http://code.google.com/p/spyderlib/issues/detail?id=820

@spyder-bot
Copy link
Collaborator Author

From ccordoba12 on 2014-08-23T13:23:14Z

Status: Accepted
Labels: Cat-Settings MS-v2.4

@goanpeca
Copy link
Member

goanpeca commented Dec 7, 2015

I am doing the redesign of the Syntax Highlighters/Color Scheme preferences of spyder.

This is an initial idea (location of buttons is subject to opinions so please jump in)

image

Clicking on create new Scheme, or Edit Selected would open something like:
image


I think the combo box should be the global color scheme selector, and every other widget should use that setting.

@goanpeca
Copy link
Member

goanpeca commented Dec 7, 2015

The color dialog could also have a "preview editor" to the right, so changes could be rendered in realtime

Also, from here it would be straightforward to export/import color schemes in other formats

@ccordoba12 ccordoba12 modified the milestones: V3.0beta3, v3.0 Dec 7, 2015
@ccordoba12
Copy link
Member

@goanpeca, awesome! This is really nice :-)

My suggestions:

  1. Could it be possible to put all the buttons to the left and the preview to the right? I mean, something like:

    Color scheme               Preview
    Edit selected
    Reset
    Delete
    Create new scheme
    
  2. The Delete button should be disabled when the selected scheme is not a custom one.

  3. As you said, later we can add buttons for Import/Export and maybe also change to use a more widely used format for schemes.

@goanpeca
Copy link
Member

goanpeca commented Dec 7, 2015

@ccordoba12

image

@ccordoba12
Copy link
Member

Nice!!

More suggestions:

  1. Change Color scheme on the dropdown menu to Scheme:. That would make the buttons below not so wide, and so nicer to look at. Also, Preview would be a bit wider.

  2. Could add some space between Delete and Create new scheme? Even better would be to show Create new scheme at the bottom of the layout.

    I'm saying this because Create new scheme is a different operation from the others, so we should show it visually separated from them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants