Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More compact 'Global working directory' toolbar #537

Closed
spyder-bot opened this issue Feb 16, 2015 · 5 comments
Closed

More compact 'Global working directory' toolbar #537

spyder-bot opened this issue Feb 16, 2015 · 5 comments

Comments

@spyder-bot
Copy link
Collaborator

From christop...@gmail.com on 2011-01-25T17:52:59Z

I have made a small patch that removes the (to my opinion) quite verbose description string in the "Global working directory" toolbar:

--- a/spyderlib/plugins/workingdirectory.py Wed Jan 19 16:40:56 2011 +0100
+++ b/spyderlib/plugins/workingdirectory.py Sat Jan 22 13:59:17 2011 +0100
@@ -159,13 +159,13 @@
self.setWindowTitle(self.get_plugin_title()) # Toolbar title
self.setObjectName(self.get_plugin_title()) # Used to save Window state

  •    label = QLabel(self.tr("Global working directory:")+" ")
    
  •    label.setToolTip(self.tr("This is the working directory for newly\n"
    
  •                             "opened consoles (Python interpreters and\n"
    
  •                             "terminals), for the file explorer, for the\n"
    
  •                             "find in files plugin and for new files\n"
    
  •                             "created in the editor"))
    
  •    self.addWidget(label)
    

    +# label = QLabel(self.tr("Global working directory:")+" ")
    +# label.setToolTip(self.tr("This is the working directory for newly\n"
    +# "opened consoles (Python interpreters and\n"
    +# "terminals), for the file explorer, for the\n"
    +# "find in files plugin and for new files\n"
    +# "created in the editor"))
    +# self.addWidget(label)

     \# Previous dir action
     self.history = []
    

    @@ -192,7 +192,12 @@
    # Path combo box
    adjust = self.get_option('working_dir_adjusttocontents', False)
    self.pathedit = PathComboBox(self, adjust_to_contents=adjust)

  •    self.pathedit.setToolTip(self.tr("Working directory"))
    
  •    self.pathedit.setToolTip(self.tr("This is the working directory for newly\n"
    
  •                             "opened consoles (Python interpreters and\n"
    
  •                             "terminals), for the file explorer, for the\n"
    
  •                             "find in files plugin and for new files\n"
    
  •                             "created in the editor"))
    

    +# self.pathedit.setToolTip(self.tr("Working directory"))
    self.connect(self.pathedit, SIGNAL("open_dir(QString)"), self.chdir)
    self.pathedit.setMaxCount(self.get_option('working_dir_history', 20))
    wdhistory = self.load_wdhistory( workdir )

Original issue: http://code.google.com/p/spyderlib/issues/detail?id=537

@spyder-bot
Copy link
Collaborator Author

From ccordoba12 on 2011-02-16T11:46:18Z

Hi Christoph,

I agree with you that "Global working directory" is just too long to fit on the toolbar, especially for people using netbooks. But your patch simply removes the name and leaves the user the responsibility to find what the toolbar is about through a tooltip, which could be another (serious?) usability problem too.

We need to think more carefully about it. What if we change the name for an icon? Something that can represent visually the idea of "working directory"?

Carlos

Status: Accepted
Labels: -Type-Defect -Priority-Medium Type-Enhancement Priority-Low

@spyder-bot
Copy link
Collaborator Author

From kristi.t...@gmail.com on 2011-03-01T00:36:16Z

I like the patch. I think the tooltip is enough for people to figure out what the directory means. (There is a folder icon directly to the right of it.) Maybe overlay an Earth icon on top of that folder icon to signify "Global" working directory.

Without the patch, I can't see what directory is being used (or rather, I can only see 5 pixels of the global working directory path). Please patch. :)

@spyder-bot
Copy link
Collaborator Author

From pierre.raybaut on 2011-03-18T00:08:29Z

This issue was closed by revision 32a01181a585 .

Status: Fixed

@spyder-bot
Copy link
Collaborator Author

From pierre.raybaut on 2011-03-19T05:40:33Z

This issue was closed by revision 4142c2fb4091 .

@spyder-bot
Copy link
Collaborator Author

From pierre.raybaut on 2011-04-24T07:38:37Z

This issue was closed by revision 32a01181a585 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants