Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 for line breaks before binary operators is incorrect #4203

Closed
mun1r0b0t opened this issue Feb 25, 2017 · 4 comments
Closed

PEP8 for line breaks before binary operators is incorrect #4203

mun1r0b0t opened this issue Feb 25, 2017 · 4 comments

Comments

@mun1r0b0t
Copy link

Hello Spyder devs,
Spyder indicates a PEP8 violation for line breaks before binary operator. However, that is the PEP8 standard.

screenshot from 2017-02-25 18-55-56

Here's the PEP8 for that.

You can reproduce the problem by writing a line with a break in front of a binary operator.
Example

    x = (1
         + 2)

This happens in Spyder version 3.1.3 on Python 3.5 and 2.7 in Linux installed with pip. I also saw this on the Windows version shipped along with WinPython.

Please update that.
Thank you.

@ccordoba12 ccordoba12 added this to the v3.3 milestone Feb 26, 2017
@bilderbuchi
Copy link

bilderbuchi commented Feb 27, 2017

PEP8 was recently changed regarding this, and the tools (here: pycodestyle) are still catching up, so this will trickle down to spyder in a while I guess. (In pycodestyle's case, the warning will be ignored by default).
See https://gitlab.com/pycqa/flake8/issues/139 PyCQA/pycodestyle#498 https://hg.python.org/peps/rev/9afe77ad549b

Close this as not-spyder's-bug?

@ccordoba12
Copy link
Member

We could switch to use pycodestyle instead of pep8, I think.

@bilderbuchi
Copy link

bilderbuchi commented Feb 27, 2017

It's the same thing... pep8 got renamed to pycodestyle. And if you have a pep8 dependency, you should change that, as it's deprecated/not developed anymore.

@ccordoba12
Copy link
Member

I know it's the same thing, but we still use pep8 as a dependency.

I'm closing this issue as a duplicate of #3197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants