Some rope_patch improvements

[spyder-bot]

From sergey.s...@gmail.com on 2013-02-27T15:17:03Z

Colleagues,
I have a few suggestions about rope_patch.py code.

1. The code in lines 195-200 looks a bit suspicious:
   def _get_single_function_docstring(self, pyfunction):
   signature = self._get_function_signature(pyfunction)
   docs = pyfunction.get_doc()
   docs = self._trim_docstring(pyfunction.get_doc(), indents=0)
   return docs
   return signature + ':\n\n' + docs

Obviously a piece of it is unreachable and pyfunction.get_doc() is called twice. What return statement is the correct one?

1. get_calltip(...) has inconsistent return statements:
   In most of the cases the function returns something or None, except of this case (lines 176-177):

if ignore_unknown and not isinstance(pyobject, pyobjects.PyFunction):
return

Should it read as "return None" to be consistent with all the other cases?

Thanks,
Sergey

Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1288

[spyder-bot]

From ccordoba12 on 2013-03-05T10:02:33Z

Thanks a lot for your sugestions. I'll look more carefully at them when I have some time and try to add them before 2.2 is definitely released.

Labels: MS-v2.2 Cat-Editor

[spyder-bot]

From ccordoba12 on 2013-03-25T09:23:21Z

Sergey:

1. You are right about it. I'm gonna fix it.
2. I checked against rope and the inconsistent return is there too, so I prefer to leave it.

Thanks for your time and suggestions.

Summary: Some rope_patch improvements (was: rope_patch.py suggestions)

[spyder-bot]

From ccordoba12 on 2013-03-25T09:26:10Z

This issue was updated by revision b0c1a000af2a .

• Thanks to Sergey Satskiy for noticing it.

Status: Fixed

[spyder-bot]

From sergey.s...@gmail.com on 2013-03-25T09:29:06Z

Thanks for the fix!

[spyder-bot]

From ccordoba12 on 2013-03-25T09:37:16Z

You're welcome!