Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus goes to kernel not client with pdb in IPython client #1069

Closed
spyder-bot opened this issue Feb 17, 2015 · 10 comments
Closed

Focus goes to kernel not client with pdb in IPython client #1069

spyder-bot opened this issue Feb 17, 2015 · 10 comments

Comments

@spyder-bot
Copy link
Collaborator

From r.lup...@gmail.com on 2012-05-30T06:20:40Z

Spyder Version: 2.2.0dev
Python Version: 2.7.2
Qt Version: 4.7.3, PyQt4 (API v2) 4.8.5 on Windows

What steps will reproduce the problem?

Using %debug in IPython client: pressing enter after pdb commands gives focus to the Console (where the IPython kernel is) rather than the IPython Console (where the client is).

The client remains visible, but any typing goes invisibly to the kernel window.

Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1069

@spyder-bot
Copy link
Collaborator Author

From ccordoba12 on 2012-05-30T06:33:22Z

Jed, could you take a look at this one?

Status: Accepted
Cc: jed.lud...@gmail.com
Labels: MS-v2.2

@spyder-bot
Copy link
Collaborator Author

From r.lup...@gmail.com on 2012-05-30T06:35:51Z

Actually I had another look and I think I have fixed it, in a similar way to execute_python_code(). A diff is attached.

Attachment: pdb_focus.patch

@spyder-bot
Copy link
Collaborator Author

From jed.lud...@gmail.com on 2012-05-30T10:23:07Z

I'll look into it shortly.

Owner: jed.lud...@gmail.com
Cc: -jed.lud...@gmail.com

@spyder-bot
Copy link
Collaborator Author

From jed.lud...@gmail.com on 2012-05-30T12:02:11Z

I've looked over the fix proposed in comment 2, and I have tested it briefly. It seems to be working just fine. Go ahead and review further and pull if desired. You can pull from this bookmark in my clone: https://code.google.com/r/jedludlow-spyderlib-default/source/browse?name=jedludlow-issue-1069

Status: Started
Cc: ccordoba12

@spyder-bot
Copy link
Collaborator Author

From ccordoba12 on 2012-05-30T21:25:30Z

I couldn't test the proposed fix, but looking at the patch it seems that it makes pdb work only for the ipython console and breaks the support for the Python one. Remember that it has to work for both of them.

Jed, can you confirm this is or not the case?

@spyder-bot
Copy link
Collaborator Author

From jed.lud...@gmail.com on 2012-05-31T04:56:53Z

I can confirm that it works for both the IPython console and the standard Python console.

@spyder-bot
Copy link
Collaborator Author

From ccordoba12 on 2012-05-31T05:33:45Z

Ok, thanks a lot! Giving your positive review I'm going to merge this in a couple of minutes.

@spyder-bot
Copy link
Collaborator Author

From jed.lud...@gmail.com on 2012-05-31T20:30:10Z

This issue was closed by revision 39567850d064 .

Status: Fixed

@spyder-bot
Copy link
Collaborator Author

From ccordoba12 on 2012-05-31T20:31:25Z

Ok, not a couple of minutes but at least today =)

@spyder-bot
Copy link
Collaborator Author

From ccordoba12 on 2012-07-05T20:14:35Z

Blocking: spyderlib:1053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant