Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a file switcher instance to this plugin #45

Closed
ccordoba12 opened this issue Mar 17, 2017 · 3 comments
Closed

Add a file switcher instance to this plugin #45

ccordoba12 opened this issue Mar 17, 2017 · 3 comments
Assignees
Milestone

Comments

@ccordoba12
Copy link
Member

ccordoba12 commented Mar 17, 2017

It'd be really nice to have it to switch among notebooks.

@goanpeca, question: Ctrl+P (the shortcut to call the switcher) is a global one right now, but I think we should use the same one here. So what do you think we should do to make that work?

Possibilities:

  1. Make Ctrl+P a plugin shortcut. Cons: Not nice because you'd have to give focus to the Editor or the notebook to make it work.
  2. Make Ctrl+P to detect the current plugin and change its behavior accordingly.
  3. Add an API for the file switcher so external plugins can register with it.
@ccordoba12 ccordoba12 added this to the v0.1 milestone Mar 17, 2017
@goanpeca
Copy link
Member

goanpeca commented Mar 21, 2017

Well probably 3, I guess? The question is, should this display notebooks only or both editor files and notebooks?

@ccordoba12
Copy link
Member Author

ccordoba12 commented Mar 21, 2017

I think notebooks. It'd be less confusing, right?

@goanpeca
Copy link
Member

Sure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants