Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Spyder's or Jupyter's context menu on right click #401

Closed
jitseniesen opened this issue Mar 21, 2023 · 3 comments
Closed

Display Spyder's or Jupyter's context menu on right click #401

jitseniesen opened this issue Mar 21, 2023 · 3 comments
Milestone

Comments

@jitseniesen
Copy link
Member

This is a follow-up from PR #396. In version 0.4, right clicking brings up Spyder's context menu (with New, Open, Save). After #396, something has changed and right-clicking brings up Jupyter's context menu.

I am not yet sure what to do about this. All actions in Spyder's context menu can also be performed via the hamburger menu, so we don't lose functionality by displaying Jupyter's context menu. Furthermore, Jupyter's context menu does have some useful stuff in it.

@jitseniesen jitseniesen added this to the v0.5 milestone Mar 21, 2023
@jitseniesen
Copy link
Member Author

I checked and actually, in version 0.4 of the plugin a right-click does display Spyder's context menu. However, at least on my system the menu does not have the "New notebook" and "Open notebook" menu items to which the text on the welcome screen refers, as shown below. This may be a regression between versions 0.3 and 0.4 (or I am not remembering it correctly).

rightclick-old

Shift+right-click shows the Qt context menu, as shown below. This was added in PR #349 because the Qt context menu has an item for saving plots.

shift-rightclick-old

After PR #396, right-click shows the Jupyter context menu instead of the menu with "Zoom in" and "Zoom out":

rightclick-new

Shift+right-click shows the same Qt context menu as before.

@ccordoba12
Copy link
Member

However, at least on my system the menu does not have the "New notebook" and "Open notebook" menu items to which the text on the welcome screen refers, as shown below

This is perhaps a regression when the plugin was migrated to the new API. I think we should address that along with increasing the dependency on Spyder (>=5.4.3 once it's released) to fix issue #386, and release 0.4.1 with those fixes.

After PR #396, right-click shows the Jupyter context menu instead of the menu with "Zoom in" and "Zoom out"

I think we should keep that menu to maintain consistency with Jupyter notebook. In that way, users that move from regular Jupyter notebook to the Spyder one would encounter the same experience.

This was referenced Mar 22, 2023
@jitseniesen jitseniesen modified the milestones: v0.5, v0.5.1 Jun 25, 2023
@jitseniesen
Copy link
Member Author

We decided to stick with the Jupyter context menu, so nothing needs to be done here.

@jitseniesen jitseniesen modified the milestones: v0.5.1, v0.5 Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants