Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanly exit notebook server #171

Closed
jitseniesen opened this issue Aug 31, 2018 · 1 comment · Fixed by #289
Closed

Cleanly exit notebook server #171

jitseniesen opened this issue Aug 31, 2018 · 1 comment · Fixed by #289
Assignees
@jitseniesen
Labels
type:Techdebt v0.3

Comments

@jitseniesen
Copy link
Member

At the moment, the notebook server is killed. However, it seems possible to shut it down the server using notebook.shutdown_server or the HTTP API. This is probably nicer.
@jitseniesen jitseniesen added this to the v0.2 milestone Aug 31, 2018
@jitseniesen jitseniesen self-assigned this Aug 31, 2018
@ccordoba12
Copy link
Member

Good idea! However, I think that would require a bump in the minimal notebook version we demand.

@jitseniesen jitseniesen modified the milestones: v0.2.0, v0.3.0 Dec 17, 2019
@goanpeca goanpeca added the v0.3 label Feb 23, 2020
@goanpeca goanpeca removed this from the v0.3.0 milestone Feb 23, 2020
@jitseniesen jitseniesen mentioned this issue Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jitseniesen jitseniesen

Labels
type:Techdebt v0.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PR: Shutdown notebook server properly jitseniesen/spyder-notebook
3 participants
@ccordoba12 @goanpeca @jitseniesen