Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more robust when starting notebook #157

Closed
jitseniesen opened this issue Aug 22, 2018 · 5 comments
Closed

Be more robust when starting notebook #157

jitseniesen opened this issue Aug 22, 2018 · 5 comments
Assignees
Labels
Milestone

Comments

@jitseniesen
Copy link
Member

From Gitter: "I also think we should start the notebook in a more robust way. Here we assume the jupyter command is in your PATH, but we could detect if that's true or not before doing it"

@jitseniesen jitseniesen added this to the v0.1.3 milestone Aug 22, 2018
@jitseniesen jitseniesen self-assigned this Aug 22, 2018
@ccordoba12
Copy link
Member

Another option would be to create a Python script that starts the notebook programatically (instead of passing options to jupyter notebook). The main class to do that is NotebookApp, I think.

Then we could start the notebook with something like:

subprocess.Popen([sys.executable, 'nb_start.py'])

@ccordoba12
Copy link
Member

#141 is also related to this. So I'd really prefer that we'd follow my last suggestion.

@jitseniesen
Copy link
Member Author

Do you have something like this PR in mind? It does not seem to require a script.

@ccordoba12
Copy link
Member

I was thinking to use a script so that the notebook server can be started in the background with subprocess. What are you thinking to solve this issue?

@ccordoba12
Copy link
Member

Sorry, I didn't see your referenced PR. I'm looking at it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants