Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing DDL migration script related to BATCH_STEP_EXECUTION table in v5 migration guide #4332

Closed
florianhof opened this issue Mar 22, 2023 · 2 comments

Comments

@florianhof
Copy link

Bug description
Documentation is incomplete: Spring Batch 5.0 Migration Guide
§Database schema updates > All platforms
It misses the migration step of renaming a column (or what I did for backward compatibility, add a new column). The doc should states something like:

Column change in BATCH_STEP_EXECUTION

The column START_TIME was renamed in CREATE_TIME. Rename it according to your database server, something like:
ALTER TABLE BATCH_STEP_EXECUTION RENAME COLUMN START_TIME TO CREATE_TIME;

Environment
Spring Batch 5.0.1, Java 17, database Postgres 14, Spring Boot 3.0.4.
Please provide as many details as possible: Spring Batch version, Java version, which database you use if any, etc

Steps to reproduce
see https://github.com/spring-projects/spring-batch/wiki/Spring-Batch-5.0-Migration-Guide#all-platforms

Expected behavior
Running a batch should works after migrating an existing batch to latest Spring Batch.

Minimal Complete Reproducible example

@florianhof florianhof added status: waiting-for-triage Issues that we did not analyse yet type: bug labels Mar 22, 2023
@fmbenhassine
Copy link
Contributor

Thank you for raising this! The statements are present in the migration script, but indeed they are missing from the migration guide.

I will update the migration guide as needed.

@fmbenhassine fmbenhassine added in: documentation and removed status: waiting-for-triage Issues that we did not analyse yet labels Mar 22, 2023
@fmbenhassine fmbenhassine added this to the 5.0.2 milestone Mar 22, 2023
@fmbenhassine fmbenhassine changed the title doc migration v5: missing renaming to CREATE_TIME Missing DDL migration script related to BATCH_STEP_EXECUTION table in v5 migration guide Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants