Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit dependency of com.squareup.okhttp3 #847

Closed
wind57 opened this issue Aug 6, 2021 · 1 comment
Closed

Remove explicit dependency of com.squareup.okhttp3 #847

wind57 opened this issue Aug 6, 2021 · 1 comment

Comments

@wind57
Copy link
Contributor

wind57 commented Aug 6, 2021

In root pom.xml we have this. So we have a bom project spring-cloud-kubernetes-dependencies, this all makes sense.

In that bom we track okhttp3 explicitly (and some other too, but these are not that important now).

At the same time, we track kubernetes-client version too. Now the problem is that kubernetes-client uses a different version of okhttp3. So, we basically override that all the time with a lower one. It's just how maven works

We should not be doing that. At the same time we can't rely on the fact that a transitive dependency will be provided to us (for the cases where our code really need okhttp3). In those cases we should include it explicitly, but the version should not be managed via bom.

This issue came into light while looking at this recent one.

@wind57
Copy link
Contributor Author

wind57 commented Aug 6, 2021

I need to think about this a bit more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants