Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any performance downgrade problem since the Go version was upgraded to 1.22? #238

Open
zigo101 opened this issue Feb 7, 2025 · 2 comments

Comments

@zigo101
Copy link

zigo101 commented Feb 7, 2025

Hi, I just noticed that the Go version of this project was upgraded to 1.22.

I have a small question: is there any performance downgrade problem caused by this line?

Sometimes, it will.

@peace-maker
Copy link
Collaborator

Thanks for the hint, it's hard to benchmark this part of the code.

How did you notice this? Using something like codeql?

@zigo101
Copy link
Author

zigo101 commented Feb 11, 2025

I found it through sourcegraph code seach.

It is hard to make a pattern to find all such cases, but I still found two (both are mentioned in golang/go#66156).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants