Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error response codes are ignored #76

Open
dhensby opened this issue Oct 12, 2022 · 0 comments
Open

Error response codes are ignored #76

dhensby opened this issue Oct 12, 2022 · 0 comments

Comments

@dhensby
Copy link

dhensby commented Oct 12, 2022

When the library sends the events to the server, if the server responds with an error status code (eg: 403) and the body cannot be parsed as expected (say because an HTML response is given), then the logger silently ignores the error and the log is treated as if it is successful.

I would suggest that error response status code like this should be dealt with as an error. Perhaps the retry logic can be short-circuited, but the error callbacks should be invoked so that the issue is not silently swallowed and ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant