GitHub action migration #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 2.12.1 to 3.0.0. - [Release notes](https://github.com/pytest-dev/pytest-cov/releases) - [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-cov@v2.12.1...v3.0.0) --- updated-dependencies: - dependency-name: pytest-cov dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
de1828c to
2427343
Compare
ghost
approved these changes
Oct 11, 2021
Co-authored-by: Artem Rys <79191415+arys-splunk@users.noreply.github.com>
|
@harshilgajera-crest Can you please also remove CLA.md and CODE_OF_CONDUCT.md? We do not need them anymore if we are migrating to CLA / COC Github action? I confirmed that with Ryan. |
ghost
suggested changes
Oct 11, 2021
There was a problem hiding this comment.
Please:
- Remove LICENSES folder
- Remove CLA.md and CODE_OF_CONDUCT.md
- Remove .reuse folder
- Change this line () to https://github.com/splunk/addonfactory-ucc-generator/blob/3f19ffbcd6f6297e96bace3d9b52dea6865d0b7c/LICENSE#L189
addonfactory-ucc-library/LICENSE
Line 189 in 8630d70
- Please run
poetry remove --devforpytest-expect,poetry-dynamic-versioning,tomlkit,reuse. - Please remove
addonfactory-ucc-library/pyproject.toml
Lines 39 to 40 in 8630d70
ghost
suggested changes
Oct 12, 2021
ghost
suggested changes
Oct 12, 2021
nariyanibhargav
approved these changes
Oct 12, 2021
ghost
reviewed
Oct 13, 2021
| @@ -181,7 +181,7 @@ jobs: | |||
| @semantic-release/git | |||
| @google/semantic-release-replace-plugin | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.SEMREL_TOKEN }} | |||
| GITHUB_TOKEN: ${{ secrets.GH_TOKEN_ADMIN }} | |||
There was a problem hiding this comment.
@uoboda-splunk I think we need to change this in solnlib as well.
|
🎉 This PR is included in version 5.0.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for migration from CircleIC to Github Actions.
For updates related to Publish to PyPi for took reference from https://github.com/splunk/addonfactory-ucc-generator
Added pre-commit lint
Added review secrets in the build-test-release workflow.
Added compliance-copyright and compliance-dependency in required for a build similar to UCC
Updated license in all required files and also updated licenserc.yaml as ignore-list file to similar to UCC
Verified the generated build by comparing with CircleCI main build only version diff.
Closes #41