Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no-compile missing from os-dependentLibraries packages #999

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix: no-compile missing from os-dependentLibraries packages #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e87a756
fix: no-compile missing from os-dependentLibraries packages
livehybrid Jan 4, 2024
cfd1efc
chore: adjust os lib tests
sgoral-splunk Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions splunk_add_on_ucc_framework/install_python_libraries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ def install_os_dependent_libraries(

pip_download_command = (
f"{os_lib.deps_flag} "
f"--no-compile "
f"--platform {os_lib.platform} "
f"--python-version {os_lib.python_version} "
f"--target {target_path}"
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/test_install_python_libraries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ def test_install_libraries_valid_os_libraries(
log_message_expected_1 = (
f"python3 -m pip install "
f"--no-deps "
f"--no-compile "
f"--platform win_amd64 "
f"--python-version 37 "
f"--target {tmp_ucc_lib_target}/3rdparty/windows "
Expand All @@ -316,6 +317,7 @@ def test_install_libraries_valid_os_libraries(

log_message_expected_2 = (
f"python3 -m pip install "
f"--no-compile "
f"--platform manylinux2014_x86_64 "
f"--python-version 37 "
f"--target {tmp_ucc_lib_target}/3rdparty/linux "
Expand All @@ -325,6 +327,7 @@ def test_install_libraries_valid_os_libraries(
log_message_expected_3 = (
f"python3 -m pip install "
f"--no-deps "
f"--no-compile "
f"--platform macosx_10_12_universal2 "
f"--python-version 37 "
f"--target {tmp_ucc_lib_target}/3rdparty/darwin "
Expand Down
Loading