Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require variable only when displayed ADDON-67013 #985

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

soleksy-splunk
Copy link
Contributor

@soleksy-splunk soleksy-splunk commented Dec 21, 2023

https://splunk.atlassian.net/browse/ADDON-67013

Add possibility to make a field required when displayed.

It is done via separate variable as for this ticket we do not want to make that variable necessarily from backend perspective.

@soleksy-splunk soleksy-splunk added the run-ui-tests If set on PR, UI tests will be run label Dec 21, 2023
@artemrys
Copy link
Member

@soleksy-splunk we miss at some testing here.

@soleksy-splunk
Copy link
Contributor Author

@soleksy-splunk we miss at some testing here.

yea thats actually the problem, as currently we do not have standard mechanism to change that state of a component, so i would need to create a custom mechanism just to check it.

I will add those tests with incoming feature, "display/hide components on other component value"

@soleksy-splunk
Copy link
Contributor Author

@soleksy-splunk we miss at some testing here.

yea thats actually the problem, as currently we do not have standard mechanism to change that state of a component, so i would need to create a custom mechanism just to check it.

I will add those tests with incoming feature, "display/hide components on other component value"

@artemrys Now when i read it might be unclear,
currently in ucc generator we do not have any mechanism to display/hide standard form fields, so there isn't any standard mechanism to actually be used here, but a there is another ticket to implement such mechanism (https://splunk.atlassian.net/browse/ADDON-67012), and that ticket will also contain tests for this variable

@artemrys artemrys merged commit 6873164 into develop Dec 27, 2023
17 checks passed
@artemrys artemrys deleted the feat/require-field-only-when-visible-ADDON-67013 branch December 27, 2023 17:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
run-ui-tests If set on PR, UI tests will be run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants