From b4359c35df0818e850fda2fea778a075e4159623 Mon Sep 17 00:00:00 2001 From: Viktor Tsvetkov <142901247+vtsvetkov-splunk@users.noreply.github.com> Date: Mon, 18 Dec 2023 14:07:48 +0100 Subject: [PATCH 1/2] chore: update nodejs to 20 --- .github/workflows/build-test-release.yml | 2 +- .github/workflows/docs.yml | 4 ++-- ui/package.json | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-test-release.yml b/.github/workflows/build-test-release.yml index f083dad95..11a0430bc 100644 --- a/.github/workflows/build-test-release.yml +++ b/.github/workflows/build-test-release.yml @@ -74,7 +74,7 @@ jobs: strategy: matrix: node-version: - - "18" + - "20" uses: ./.github/workflows/build-ui.yml with: node-version: ${{ matrix.node-version }} diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 964f7fae0..ed25971c8 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -16,11 +16,11 @@ jobs: python-version: 3.7 - uses: actions/setup-node@v3 with: - node-version: "18" + node-version: "20" - name: install deps uses: ./.github/actions/cached-ui-deps with: - node-version: "18" + node-version: "20" - name: Build Storybook run: | cd ui diff --git a/ui/package.json b/ui/package.json index 4cebe5d48..a3fa0e04d 100644 --- a/ui/package.json +++ b/ui/package.json @@ -106,8 +106,8 @@ "string-width": "^4.2.2" }, "engines": { - "node": ">=18", - "yarn": "^1" + "node": ">=20.10.0", + "yarn": "^1.22.21" }, "msw": { "workerDirectory": "src/public" From bc0ed669c933c1a29496a7150e16820c84c1fa33 Mon Sep 17 00:00:00 2001 From: Viktor Tsvetkov <142901247+vtsvetkov-splunk@users.noreply.github.com> Date: Mon, 18 Dec 2023 14:25:25 +0100 Subject: [PATCH 2/2] update docs --- docs/contributing.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributing.md b/docs/contributing.md index 690def907..4eec52443 100644 --- a/docs/contributing.md +++ b/docs/contributing.md @@ -5,7 +5,7 @@ Default development branch is `develop`. Please use it for PR ## Build and Test Prerequisites: -- Node.js >= 18 ([NodeJS](https://nodejs.org/en/download) or use [nvm](https://github.com/nvm-sh/nvm)) +- Node.js LTS version ([NodeJS](https://nodejs.org/en/download) or use [nvm](https://github.com/nvm-sh/nvm)) - Yarn Classic (`npm install --global yarn`) - Poetry 1.5.1. [Installation guide](https://python-poetry.org/docs/#installing-with-the-official-installer)