fix: fix enable for entities and add it for OAuth #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtsvetkov-splunk
requested changes
Dec 8, 2023
| @@ -87,26 +150,72 @@ describe('EntityModal - Oauth oauth', () => { | |||
| renderModalWithProps(props); | |||
| const oauthTextBox = getDisabledOauthField(); | |||
| expect(oauthTextBox).toBeInTheDocument(); | |||
| expect(oauthTextBox?.getAttribute('disabled')).toBeNull(); | |||
| expect(oauthTextBox?.getAttribute('disabled')).toBe(''); | |||
There was a problem hiding this comment.
Suggested change
| expect(oauthTextBox?.getAttribute('disabled')).toBe(''); | |
| expect(oauthTextBox).toHaveAttribute('disabled'); |
the current version:
my suggestion:
There was a problem hiding this comment.
but it is not...?
There was a problem hiding this comment.
yea sorry, somehow i missed 2 out of 8 lines, should be done now
| renderModalWithProps(props); | ||
|
|
||
| const oauthTextBox = getDisabledOauthField(); | ||
| expect(oauthTextBox).toBeInTheDocument(); | ||
| expect(oauthTextBox?.getAttribute('disabled')).toBe(''); |
There was a problem hiding this comment.
Suggested change
| expect(oauthTextBox?.getAttribute('disabled')).toBe(''); | |
| expect(oauthTextBox).not.toHaveAttribute('disabled'); |
There was a problem hiding this comment.
but it is not ..?
90f37f5 to
bd35d3c
Compare
vtsvetkov-splunk
requested changes
Dec 14, 2023
| @@ -87,26 +150,72 @@ describe('EntityModal - Oauth oauth', () => { | |||
| renderModalWithProps(props); | |||
| const oauthTextBox = getDisabledOauthField(); | |||
| expect(oauthTextBox).toBeInTheDocument(); | |||
| expect(oauthTextBox?.getAttribute('disabled')).toBeNull(); | |||
| expect(oauthTextBox?.getAttribute('disabled')).toBe(''); | |||
There was a problem hiding this comment.
but it is not...?
| renderModalWithProps(props); | ||
|
|
||
| const oauthTextBox = getDisabledOauthField(); | ||
| expect(oauthTextBox).toBeInTheDocument(); | ||
| expect(oauthTextBox?.getAttribute('disabled')).toBe(''); |
There was a problem hiding this comment.
but it is not ..?
vtsvetkov-splunk
approved these changes
Dec 14, 2023
artemrys
approved these changes
Dec 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a replacement for account_hook.js for repo https://github.com/splunk/splunk-add-on-for-okta-identity-cloud
parent ticket https://splunk.atlassian.net/browse/ADDON-65747
fix for enable property for every entity/field and adding support of it for oauth fields
https://splunk.github.io/addonfactory-ucc-generator/entity/
Adding tests for default value in oauth fields, logic existed there it was just not permitted in schema.