Feat/build verbose argument #918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot: All contributors have NOT signed the COC Document I have read the Code of Conduct and I hereby accept the Terms You can retrigger this bot by commenting recheck in this Pull Request |
artemrys
requested changes
Oct 23, 2023
| @@ -34,3 +34,4 @@ output | |||
| .gitmodules | |||
| .pytest_cache/** | |||
| site/ | |||
| temp_add_on | |||
There was a problem hiding this comment.
Please remove this line, this one is specific to your env.
Comment on lines
+338
to
+352
| conflict_static_list =[ | ||
| 'import_declare_test.py', | ||
| f'{ta_name}_rh_*.py', | ||
| 'app.conf', | ||
| 'inputs.conf*', | ||
| 'restmap.conf', | ||
| 'server.conf', | ||
| f'{ta_name}_*.conf*', | ||
| 'web.conf', | ||
| 'default.xml', | ||
| 'configuration.xml', | ||
| 'dashboard.xml', | ||
| 'inputs.xml', | ||
| 'openapi.json' | ||
| ] |
There was a problem hiding this comment.
Can we use the full path to the files instead of trying to match with regex?
Comment on lines
+329
to
+333
| color_pallete = { | ||
| 'copied': c.Fore.GREEN, | ||
| 'conflict': c.Fore.RED, | ||
| 'modified': c.Fore.YELLOW, | ||
| } |
There was a problem hiding this comment.
Is this going to work if we use logging instead of print?
Signed-off-by: Mateusz Macalik <mmacalik@splunk.com>
33369db to
e64f087
Compare
|
The dev of this feature is now happening here: #927 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.