Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove comments support from app.manifest file #753

Merged

Conversation

artemrys
Copy link
Member

@artemrys artemrys commented May 6, 2023

From now on, we are not going to support comments in app.manifest file.

From now on, we are not going to support comments in app.manifest file.
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Merging #753 (14ab2c6) into release/v5.27.0 (f1820e0) will increase coverage by 68.97%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                 Coverage Diff                  @@
##           release/v5.27.0     #753       +/-   ##
====================================================
+ Coverage                 0   68.97%   +68.97%     
====================================================
  Files                    0       41       +41     
  Lines                    0     2134     +2134     
  Branches                 0      404      +404     
====================================================
+ Hits                     0     1472     +1472     
- Misses                   0      641      +641     
- Partials                 0       21       +21     
Impacted Files Coverage Δ
splunk_add_on_ucc_framework/commands/build.py 13.20% <ø> (ø)
splunk_add_on_ucc_framework/app_manifest.py 100.00% <100.00%> (ø)

... and 39 files with indirect coverage changes

@artemrys artemrys merged commit 4856548 into release/v5.27.0 May 6, 2023
@artemrys artemrys deleted the feat/remove-comments-support-from-app-manifest branch May 6, 2023 10:52
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants