Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OpenAPI generator for UCC #648

Merged
merged 18 commits into from
Feb 21, 2023
Merged

feat: OpenAPI generator for UCC #648

merged 18 commits into from
Feb 21, 2023

Conversation

hsekowski-splunk
Copy link
Contributor

@hsekowski-splunk hsekowski-splunk commented Feb 14, 2023 •
edited by artemrys
Loading

OpenAPI implementation feature for UCC framework. The resulting openapi.json file will be placed under static folder. The implementation is based on globalConfig and app.manifest files. app.manifest is needed to get the license and author information, when globalConfig is used to get all the information about the endpoints that are generated.

Original PR: #641

artemrys and others added 11 commits February 13, 2023 16:58
@artemrys
chore: update deps (#626)
e022df4
@hsekowski-splunk @artemrys
feat: openapi generator code moved and initially adopted
92e3dd8
@hsekowski-splunk @artemrys
fix: outputdir and openapi.json can be created
818aaf0
@hsekowski-splunk @artemrys
fix: openapi.json should be in static directory
31b6c5c
@hsekowski-splunk @artemrys
chore: smoke tests for openapi added
01d6099
@hsekowski-splunk @artemrys
fix: ta_version forced
cdd17e4
@hsekowski-splunk @artemrys
Update splunk_add_on_ucc_framework/commands/openapi_generator/json_to…
2c5b82a 
…_object.py

Co-authored-by: Artem Rys <rysartem@gmail.com>
@hsekowski-splunk @artemrys
Update splunk_add_on_ucc_framework/commands/openapi_generator/json_to…
db202a5 
…_object.py

Co-authored-by: Artem Rys <rysartem@gmail.com>
@hsekowski-splunk @artemrys
Update splunk_add_on_ucc_framework/app_manifest.py
caf1a4d 
Co-authored-by: Artem Rys <rysartem@gmail.com>
@hsekowski-splunk
chore: modifications to satisfy PR comments
c3ed560
@hsekowski-splunk
fix: ta_version param taken into consideration when generating openapi
ac3900c
@github-actions
Copy link

github-actions bot commented Feb 14, 2023 •
edited
Loading

CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅

@artemrys artemrys changed the base branch from release/v5.21.0 to main February 17, 2023 14:31
@artemrys artemrys changed the base branch from main to release/v5.21.0 February 17, 2023 14:31
hsekowski-splunk
hsekowski-splunk commented Feb 21, 2023
View reviewed changes
Copy link
Contributor Author

@hsekowski-splunk hsekowski-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General ask is to enable openapi by default and improve examples for openapi endpoints if possible

artemrys
artemrys approved these changes Feb 21, 2023
View reviewed changes
@artemrys artemrys merged commit 4c4e330 into release/v5.21.0 Feb 21, 2023
@artemrys artemrys deleted the new-open-api branch February 21, 2023 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@artemrys artemrys artemrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsekowski-splunk @artemrys