Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix logging #333

Merged
1 commit merged into from
Aug 26, 2021
Merged

chore: fix logging #333

1 commit merged into from
Aug 26, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 25, 2021

Used to be:

2021-08-25 21:09:35,905 [UCC] INFO: Replace tokens in views
INFO:UCC:Replace tokens in views
2021-08-25 21:09:35,930 [UCC] INFO: Copy package directory
INFO:UCC:Copy package directory
2021-08-25 21:09:35,975 [UCC] INFO: Copy LICENSES directory
INFO:UCC:Copy LICENSES directory

After this PR:

2021-08-25 21:11:29,714 [UCC] INFO: Install add-on requirements into /Users/arys/src/splunk-add-on-for-cisco-meraki/output/Splunk_TA_cisco_meraki/lib from package
2021-08-25 21:11:29,714 [UCC] INFO:   Checking for requirements in package
2021-08-25 21:11:29,714 [UCC] INFO:   Not using common requirements
2021-08-25 21:11:29,716 [UCC] INFO: Replace tokens in views
2021-08-25 21:11:29,746 [UCC] INFO: Copy package directory
2021-08-25 21:11:29,792 [UCC] INFO: Copy LICENSES directory

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #333 (f6c4b6a) into main (9bc969b) will not change coverage.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #333   +/-   ##
=======================================
  Coverage   79.47%   79.47%           
=======================================
  Files          28       28           
  Lines        1866     1866           
=======================================
  Hits         1483     1483           
  Misses        383      383           
Impacted Files Coverage Δ
splunk_add_on_ucc_framework/__init__.py 76.98% <60.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc969b...f6c4b6a. Read the comment docs.

@ghost ghost requested a review from ricardom-splunk August 26, 2021 11:58
@ghost ghost merged commit 2aa014b into main Aug 26, 2021
@ghost ghost deleted the chore/fix-logging branch August 26, 2021 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2021
@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 5.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants