Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add appinspect check for expected output folder #305

Closed
wants to merge 22 commits into from
Closed

test: add appinspect check for expected output folder #305

wants to merge 22 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 7, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2021 •
edited
Loading

Codecov Report

Merging #305 (3a1162d) into main (6cc76bd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files          28       28           
  Lines        1953     1953           
=======================================
  Hits         1500     1500           
  Misses        453      453

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc76bd...3a1162d. Read the comment docs.

@ghost ghost force-pushed the test/appinspect-check-for-expected-output branch 10 times, most recently from 3d05e18 to 53f2893 Compare August 7, 2021 15:20
@ghost ghost force-pushed the test/appinspect-check-for-expected-output branch from 3e45871 to eb3796a Compare August 11, 2021 16:06
artemrys and others added 14 commits August 11, 2021 18:08
@artemrys
ci: use expected folder instead of package
b6f95dc
@artemrys
ci: run for multiple tags
23ae4bf
@artemrys
ci: continue-on-error=true
c2760e9
@artemrys
test: add icons
3a1162d
@artemrys
ci: bump version after release
c50b19b
@artemrys
feat: generate metadata/default.meta
76af135
@artemrys
style: fix flake8
11068e9
@artemrys
fix: release
097e937
@mchavda-splunk @artemrys
fix: Dont remove jsonschema metadata files
b7bcd99
@artemrys
feat(python): retain dist info files
8215971 
While not required by pep standard to be retained in venv some packages use these files to track their version and are broken if we remove them. We have no specific reason other than to "tidy" the package so we will no longer do this
@semantic-release-bot @artemrys
chore(release): 5.7.0
8895e09 
# [5.7.0](v5.6.2...v5.7.0) (2021-08-14)

### Bug Fixes

* Dont remove jsonschema metadata files ([539d8f6](539d8f6))
* release ([185dd15](185dd15))

### Features

* **python:** retain dist info files ([7c8616a](7c8616a))
* generate metadata/default.meta ([629b248](629b248))
@artemrys
ci: fix issues after merges
14090fb
@artemrys
feat: delete apiVersion from globalConfig.json and bump schemaVersion
626549f 
`apiVersion` from globalConfig is not used.
@artemrys
style: flake8
54bee7f
semantic-release-bot and others added 4 commits August 16, 2021 23:08
@semantic-release-bot @artemrys
chore(release): 5.8.0
20f7450 
# [5.8.0](v5.7.0...v5.8.0) (2021-08-16)

### Features

* delete `apiVersion` from globalConfig.json and bump schemaVersion ([6c22704](6c22704))
@artemrys
ci: try with one check
29c12b1
@artemrys
ci: run for multiple tags
f060ccc
@artemrys
fix: add icon_path
c77f8d8
@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

2 out of 4 committers have signed the CLA.
✅ @arys-splunk
✅ @rfaircloth-splunk
❌ @mchavda-splunk
❌ @semantic-release-bot
You can retrigger this bot by commenting recheck in this Pull Request

@github-actions
Copy link

CLA Assistant Lite bot: All contributors have NOT signed the COC Document

I have read the Code of Conduct and I hereby accept the Terms

3 out of 4 committers have signed the CLA.
✅ @arys-splunk
✅ @mchavda-splunk
✅ @rfaircloth-splunk
❌ @semantic-release-bot
You can retrigger this bot by commenting recheck in this Pull Request

@ghost
Copy link
Author

ghost commented Aug 18, 2021

Closing this one in favour of #327

@ghost ghost closed this Aug 18, 2021
@ghost ghost deleted the test/appinspect-check-for-expected-output branch August 18, 2021 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codecov-commenter @artemrys @mchavda-splunk @ryanfaircloth @semantic-release-bot