Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract copy-pasted code into a separate function #240

Merged
1 commit merged into from
Jun 24, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 23, 2021

Add tests to verify that updating biased terms in globalConfig.json is working as expected.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 187 files.

Valid Invalid Ignored Fixed
49 2 136 0
Click to see the invalid file list
  • tests/unit/helpers.py
  • tests/unit/test_config_file_update.py

@ghost ghost force-pushed the refactor/remove-copy-pasted-code branch from b1c3869 to da480c4 Compare June 23, 2021 15:18
Add tests to verify that updating biased terms in globalConfig.json is working as expected.
@ghost ghost force-pushed the refactor/remove-copy-pasted-code branch from da480c4 to faf5383 Compare June 23, 2021 15:31
@codecov-commenter
Copy link

Codecov Report

Merging #240 (da480c4) into main (b5ddef4) will increase coverage by 1.27%.
The diff coverage is 96.55%.

❗ Current head da480c4 differs from pull request most recent head faf5383. Consider uploading reports for the commit faf5383 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   56.30%   57.57%   +1.27%     
==========================================
  Files          37       39       +2     
  Lines        2499     2527      +28     
==========================================
+ Hits         1407     1455      +48     
+ Misses       1092     1072      -20     
Impacted Files Coverage Δ
splunk_add_on_ucc_framework/__init__.py 73.20% <92.59%> (+5.66%) ⬆️
tests/unit/helpers.py 100.00% <100.00%> (ø)
tests/unit/test_config_file_update.py 100.00% <100.00%> (ø)
tests/unit/test_config_validation.py 78.94% <100.00%> (-21.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ddef4...faf5383. Read the comment docs.

@ghost ghost requested a review from harshpatel-crest June 24, 2021 13:44
@ghost ghost marked this pull request as ready for review June 24, 2021 13:44
@ghost ghost merged commit 52fa6a6 into main Jun 24, 2021
@ghost ghost deleted the refactor/remove-copy-pasted-code branch June 24, 2021 20:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2021
@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 5.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants