Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quick fix for ta-version argument #215

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 7, 2021

Checked locally, works fine with and without ta-version.
When specifying a ta-version argument, for example: ucc-gen --ta-version=3.0.0, it will create a VERSION file with the following content:

3.0.0
3.0.0

@ghost ghost requested a review from ryanfaircloth June 7, 2021 13:52
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@github-actions
Copy link

github-actions bot commented Jun 7, 2021

Expected release notes (by @arys-splunk)

fixes:
quick fix for ta-version argument (e26e8bf)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@ryanfaircloth ryanfaircloth merged commit 2dc9e48 into main Jun 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2021
@ryanfaircloth
Copy link
Contributor

🎉 This PR is included in version 5.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ghost ghost deleted the fix/ta-version-quick-fix branch June 11, 2021 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants