Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix pipeline for forks #1040

Merged
merged 6 commits into from
Feb 1, 2024
Merged

ci: fix pipeline for forks #1040

merged 6 commits into from
Feb 1, 2024

Conversation

sgoral-splunk
Copy link
Contributor

@sgoral-splunk sgoral-splunk commented Feb 1, 2024 •
edited
Loading

skip THIRDPARTY build substeps for fork pull requests

@sgoral-splunk sgoral-splunk force-pushed the chore/fix_pipeline_for_forks branch from f2e209c to 571cf67 Compare February 1, 2024 13:02
@sgoral-splunk sgoral-splunk marked this pull request as ready for review February 1, 2024 14:14
@sgoral-splunk sgoral-splunk requested review from a team as code owners February 1, 2024 14:14
@artemrys
Copy link
Member

artemrys commented Feb 1, 2024

@sgoral-splunk can you please rebase your PR? and ci maybe a better fit for this PR

@sgoral-splunk sgoral-splunk force-pushed the chore/fix_pipeline_for_forks branch from 571cf67 to de26893 Compare February 1, 2024 14:19
@sgoral-splunk sgoral-splunk changed the title chore: fix pipeline for forks ci: fix pipeline for forks Feb 1, 2024
artemrys
artemrys reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also skip fossa and release steps? They will fail anyways using this approach.

@sgoral-splunk
Copy link
Contributor Author

Should we also skip fossa and release steps? They will fail anyways using this approach.

If we will skip fossa, build won't trigger. We would need to remove fossa from "needs" in build.

@artemrys artemrys merged commit b56e8b4 into develop Feb 1, 2024
49 of 51 checks passed
@artemrys artemrys deleted the chore/fix_pipeline_for_forks branch February 1, 2024 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@artemrys artemrys artemrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgoral-splunk @artemrys