Catch master from develop #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional tabs and spaces from the string and using that method in table.py
…tps://git.splunk.com/scm/soln/ta-ui-framework into feature/ADDON-22198-MSCS-UI-Automation-Framework
…tps://git.splunk.com/scm/soln/ta-ui-framework into feature/ADDON-22198-MSCS-UI-Automation-Framework
…elated dependencies
-MSCS-UI-Automation-Framework to develop * commit '5271902e632c6a523acc514525ce69b01f6394dd': (23 commits) ADDON-22198: Added a commet learn_more::LearnMore::go_to_link() ADDON-22198: Removed sleep time from delete row and added in get table Added sleep time in deleterow ADDON-22198: Changed the import statements ADDON-22198: Changed the import statement in init file ADDON-22198: Moved Controls directory to Components and changed the related dependencies ADDON-22198: Removed add_btn parameter from Dropdown class ADDON-22198: Reverted back the change in Dropdown select method to resolve failures ADDON-22198: Fixed 'select' method in Dropdown ADDON-22198: Removed unused elements and print statements ADDON-22198: Added single_stanza parameter while parsing conf ADDON-22198: Change in switch_to_page method to fix the failing test case ADDON-22198: Updated go_to_link() function. ADDON-22198: Did the changes to switch tab in safari. Fixed the issue with list_of_values method ADDON-22198: Change in list_of_values method of SingleSelect ADDON-22198: Added a method in base component which removes the additional tabs and spaces from the string and using that method in table.py Increased sleep time in learn_more control ADDON-22198: Added strip in get methods to resolve issues with safari ADDON-22198: Changes to resolve the failures ...
-servicenow-changing-math.random-to-crypto.getrandom to develop * commit 'e4fcc34bc2349378374df1ed9c55f07303559ba4': ADDON-26093: implementing state parameter using uuid4 ADDON-26093: Increasing 10 to 36
…-upgrade-httplib2-version to develop * commit '496e778b543e4a8f288ec9bcde23954faa67d017': ADDON-26862: updating the release versions of UCC framework ADDON-26862: upgrading httplib2 to version v0.18.1
-poc-restructure-add-on-s-third-party-libraries to develop * commit '7393a2854aa2742aca77fcf6b6af6e78eff49186': ADDON-27042: reverting unaffected changes ADDON-27038: rectifying README file ADDON-27038: updating UCC framework version and README file ADDON-27042: removing future's egg-info dependency ADDON-27042: restructured alert action files ADDON-27042: making generic changes for the common third party libraries
-UCC-remove-the-unnecessary-imports-of-httplib2_helper to develop * commit 'e872abb59bf77b58c1b28c4f8e48fd62252ce0ed': ADDON-27349: Updated the version of ta-ui-framework ADDON-27349: Removed the httplib2_helper imports
…-snow-error-related-to-global-config-json-not-found-is-occuring-with-alert-action to develop * commit 'fd1f3437309d86710782f062b55aa637e053d9c7': ADDON-27495: Changing the Jira id ADDON-27495: Keeping code consistency in remote and local version of splunk_aoblib ADDON-27495: Updated package.json ADDON-27495: Updated Readme.md ADDON-27495: Updating setup_util.py ADDON-27495: Fixing basedir in splunk_aoblib
-upgrade-jinja-version-2.9-to-2.10-due-to-white-source-vulnerability to develop * commit 'acaa8f35ec822c61043b298662d849413536b42c': ADDON-27875: Updating TA_UI version docs ADDON-27875: Upgrading jinja version
vtsvetkov-splunk
pushed a commit
that referenced
this pull request
Oct 4, 2023
srv-rr-github-token
added a commit
that referenced
this pull request
Oct 4, 2023
# [5.31.0](v5.30.0...v5.31.0) (2023-10-04) ### Bug Fixes * Add ci ([#1](#1)) ([41c5a1a](41c5a1a)) * add classNames and data-test attributes to elements for SmartX ([254a1d1](254a1d1)) * add CSS id to button ([6859943](6859943)) * add data-name attribute in ControlGroup for ease in writing automated UI tests ([10da489](10da489)) * add data-test-loading for Select ([42a165d](42a165d)) * add ids to tab container in configuration page ([2a29d2f](2a29d2f)) * add notice in release tarball ([a4590e5](a4590e5)) * add schema.json in release tarball ([c474e7b](c474e7b)) * added comment ([f96adf1](f96adf1)) * added help text link support ([6c94df9](6c94df9)) * ADDON-61204 Remove support of placeholder property ([2677cf9](2677cf9)) * ADDON-61381 Fixed the design issue in Safari browser ([#386](#386)) ([b6a7195](b6a7195)) * ADDON-62193 encoded the redirect_uri upon opening the popup ([#401](#401)) ([3be7506](3be7506)) * ADDON-62948 Added support for subTitle field in service ([#403](#403)) ([d1a5af1](d1a5af1)) * ADDON-64637 add input value to query for menu navigation ([3ca0c43](3ca0c43)) * bug fixes related to input and configuration page ([ca21343](ca21343)) * bugs ([56f5a79](56f5a79)) * bump version ([90719c4](90719c4)) * change in order of validations ([1d10657](1d10657)) * changed let to const to fix eslint error ([65ba327](65ba327)) * className missing in styled title and subtitle ([9328e85](9328e85)) * cleared fields for other authentication methods when using one ([deb2a54](deb2a54)) * **code:** ADDON-46211 Fiixed the issue to set the dynmic placeholder ([#117](#117)) ([37e5488](37e5488)) * **code:** ADDON-47626 Fixed the sorting issue for custom mapping ([#118](#118)) ([97b5cb2](97b5cb2)) * **CODE:** ADDON-47714 Fixed dependent field reset issue ([#120](#120)) ([51d9f58](51d9f58)) * **CODE:** ADDON-56621 Fixed the account/appliance with same name as tabs name conflict ([#121](#121)) ([ff1db3a](ff1db3a)) * **CODE:** ADDON-56881 Fixed the line breaker issue ([#134](#134)) ([28cff26](28cff26)) * **CODE:** ADDON-57152 Fixed tabs clicking issue when style is set to page ([#170](#170)) ([4974d59](4974d59)) * **CODE:** ADDON-57949 Fixed the custom menu with style property related issue ([#167](#167)) ([cecb3f1](cecb3f1)) * **CODE:** ADDON-58763 Fixed typo ([#179](#179)) ([1c74fae](1c74fae)) * **CODE:** ADDON-58867 Fixed cancelling selected dropdown value ([#188](#188)) ([0144432](0144432)) * custom cell/row should re-render when row is updated ([d285772](d285772)) * default to `basic` oauth_type if `undefined` to handle upgrade scenario for some add-ons ([db009eb](db009eb)) * dependabot alert for `postcss` ([b4126b7](b4126b7)) * dependabot reported security issues for `css-what` and `glob-parent` packages ([228b4c9](228b4c9)) * downgrade splunkui to 4.0.0 ([80ef18f](80ef18f)) * dynamically cleared out fields ([d12a970](d12a970)) * enforce logic for displaying clear button for singleselect when its disabled ([d430c85](d430c85)) * enhance toast message for `MODE_CONFIG`, surround entity names in double quotes and remove optional placeholder for oauth fields as its conflicting ([e5fe24d](e5fe24d)) * eslint and semgrep ([9b36bea](9b36bea)) * eslint failures ([b5edf0f](b5edf0f)) * fallback to latest form state if resthandler skips some table fields from response ([85a668c](85a668c)) * form submit should wait for state update from custom hook onSave ([9e19fa5](9e19fa5)) * formatted the code ([c736188](c736188)) * handle value `undefined` in table sort ([05b854a](05b854a)) * handled validation of optional fields in case of null value ([18d0c35](18d0c35)) * handled warnings and updated the changes ([c8240d5](c8240d5)) * Include license in pack ([0bcd002](0bcd002)) * include license with output ([5fbaf98](5fbaf98)) * keep only one way routing as done in ucc < 5 ([82b3aa7](82b3aa7)) * load dependent fields on form create ([b85516d](b85516d)) * missing files ([fc5a191](fc5a191)) * moved location of redirect_page.js ([86b44f5](86b44f5)) * overrun ([570b447](570b447)) * panels are required with at least 1 panel inside ([#382](#382)) ([eff3566](eff3566)) * parse boolean of `disabled` before setting it in state ([da76a93](da76a93)) * pass `count` query param in rest to overcome default thirty records limit ([245a3d8](245a3d8)) * pass empty string to i18n if the field is optional ([c045d18](c045d18)) * pass row and field to custom cell/row for processing on re-render ([f5a845e](f5a845e)) * precedence of autoCompleteFields vs. endpointUrl and label-value mapping for handling form save without click or enter event on combobox option ([0db4606](0db4606)) * precendence for multiselect items fetching ([02339bf](02339bf)) * priority for placeholder of optional fields ([405db62](405db62)) * remove extra rows which are empty in moreInfo ([5fbda62](5fbda62)) * remove redirect_url field from conf file ([9be7d81](9be7d81)) * remove unused code comments ([b4752d3](b4752d3)) * resolve missed `type` param for custom input row feature ([#84](#84)) ([fe17252](fe17252)) * revert "feat: ADDON-61556 Introduced checkbox group component ([#394](#394))" ([#428](#428)) ([358b1be](358b1be)) * revert 0497ac4e2e961ac141307a3ab7e6790e9bd31705 ([#309](#309)) ([e77242f](e77242f)) * **routing:** handle record param deletion on wrong tab and fix tab change due to missing dep in useCallback ([a9fe88b](a9fe88b)) * **schema.json:** add required configuration field ([#442](#442)) ([c3af60b](c3af60b)) * security warning for @npmcli/git ([e6847a6](e6847a6)) * singleSelect null value not being posted in form submit and add mapping support for heading in globalConfig ([94e11c3](94e11c3)) * skip `null` value fields from displaying in table expansion row ([7448eb8](7448eb8)) * **smartx:** add selectors for better testing ([ed2c153](ed2c153)) * toast notification not displaying when table is missing ([67b3f12](67b3f12)) * typo in comment for base form sumbitting ([d8634a1](d8634a1)) * UI breaking when globalConfig does not have inputs config ([7cf8708](7cf8708)) * update form hook onCreate error handling ([4a66418](4a66418)) * update license files ([09ac164](09ac164)) * update license in package ([0778aea](0778aea)) * update notice file ([79c5e74](79c5e74)) * update notice file ([a0b6d3f](a0b6d3f)) * update notice file ([d78e9a3](d78e9a3)) * update notice file ([840796a](840796a)) * Update NOTICE file ([#29](#29)) ([676d4c0](676d4c0)) * update react ui version to 4.0.0 ([78c4c10](78c4c10)) * update react-ui version, add class to title and subtitle components and update error message ([b79a6f5](b79a6f5)) * updated changes and added text with link support ([e14c940](e14c940)) * updated review changes ([85030c3](85030c3)) * updated review changes ([1ea41a6](1ea41a6)) * updated textbox width and changed field value for custom cell ([713954e](713954e)) * variable naming for status mapping ([74c7c6a](74c7c6a)) ### Features * add ComboBox and Select conditional rendering based on globalConfig options ([dbca65a](dbca65a)) * add DashboardPanel-s to dashboard ([#381](#381)) ([882f952](882f952)) * add label support for ([ccb1a4d](ccb1a4d)) * add meta.checkForUpdates field ([#433](#433)) ([5d92e96](5d92e96)) * add new default XML file without input ([#114](#114)) ([a359a0e](a359a0e)) * add support for globalConfig.yaml as well as JSON ([#116](#116)) ([725bc5c](725bc5c)) * add support of `required` param in oauth config ([f5bdce3](f5bdce3)) * add UI feature to enable/disable inputs in bulk ([#437](#437)) ([ab471d0](ab471d0)) * Added support of group fields ([b297deb](b297deb)) * **ADDON-37808:** enhance UX and UI for the error pages ([ec702f5](ec702f5)) * ADDON-57046: Added file input component ([#187](#187)) ([e0fb336](e0fb336)) * ADDON-57152 added tabs feature in the Inputs page ([#133](#133)) ([a3d9cb1](a3d9cb1)) * ADDON-61556 Introduced checkbox group component ([#394](#394)) ([9ffed80](9ffed80)) * ADDON-62948 Added support for subTitle field in service ([#402](#402)) ([6acd7cd](6acd7cd)) * ADDON-65006 add group name to URL when redirecting with Menu ([#429](#429)) ([9130b01](9130b01)) * allow esm JS modules as custom ui extensions to support external deps ([a2cc734](a2cc734)) * apiVersion is not required anymore ([6d4bf23](6d4bf23)) * **CODE:** ADDON-57044 Added new support for Textarea field ([#180](#180)) ([69a62b5](69a62b5)) * **CODE:** ADDON-58172 Version bump all the deps ([#175](#175)) ([50d98f8](50d98f8)) * **CODE:** ADDON-58506 Improve table using docked property ([#181](#181)) ([041452f](041452f)) * codeql ([729f42e](729f42e)) * Custom menu implementation ([58b0571](58b0571)) * First checking ([5648478](5648478)) * publish JS dependencies to appserver/package/static/js/dependencies.txt ([#103](#103)) ([3236b1b](3236b1b)) * release v1.19.0 ([#218](#218)) ([e23fbc6](e23fbc6)), closes [#201](#201) [#207](#207) [#208](#208) [#209](#209) [#210](#210) [#211](#211) [#212](#212) [#217](#217) * release v1.20.0 ([#236](#236)) ([996a463](996a463)), closes [#224](#224) [#225](#225) [#226](#226) * release v1.21.0 ([#271](https://github.com/splunk/addonfactory-ucc-generator/issues/271)) ([0e5df40](0e5df40)), closes [#238](#238) [#239](#239) [#240](#240) [#249](#249) [#250](#250) [#251](#251) [#252](#252) [#258](#258) * release v1.22.0 ([#293](#293)) ([9589e4a](9589e4a)), closes [#281](#281) [#282](#282) [#283](#283) [#291](#291) [#294](#294) * release v1.23.0 ([#306](#306)) ([7af8c06](7af8c06)), closes [#295](#295) [#297](#297) [#296](#296) [#305](#305) * release v1.24.0 ([#342](#342)) ([dff3799](dff3799)), closes [#328](#328) [#333](#333) * release v1.25.0 ([#362](#362)) ([305e13b](305e13b)), closes [#360](#360) [#361](#361) * Resolved comments ([6e7e424](6e7e424)) * Resolved review comments ([5998974](5998974)) * search internal logs button ([#371](#371)) ([439b0f6](439b0f6)) * support custom REST handlers ([#127](#127)) ([9b7ee29](9b7ee29)) * support placeholder entity type ([dd79c29](dd79c29)) * support placeholder in `globalConfig.json` for oauth fields ([8c90380](8c90380)) * trigger release (checkbox groups feature) ([#440](#440)) ([3c55957](3c55957)) * Updated dependencies ([ea02b95](ea02b95)) * use lazy loading for custom ui extensions ([7b3f349](7b3f349))
srv-rr-github-token
added a commit
that referenced
this pull request
Oct 4, 2023
# [5.31.0](v5.30.0...v5.31.0) (2023-10-04) ### Bug Fixes * Add ci ([#1](#1)) ([41c5a1a](41c5a1a)) * add classNames and data-test attributes to elements for SmartX ([254a1d1](254a1d1)) * add CSS id to button ([6859943](6859943)) * add data-name attribute in ControlGroup for ease in writing automated UI tests ([10da489](10da489)) * add data-test-loading for Select ([42a165d](42a165d)) * add ids to tab container in configuration page ([2a29d2f](2a29d2f)) * add notice in release tarball ([a4590e5](a4590e5)) * add schema.json in release tarball ([c474e7b](c474e7b)) * added comment ([f96adf1](f96adf1)) * added help text link support ([6c94df9](6c94df9)) * ADDON-61204 Remove support of placeholder property ([2677cf9](2677cf9)) * ADDON-61381 Fixed the design issue in Safari browser ([#386](#386)) ([b6a7195](b6a7195)) * ADDON-62193 encoded the redirect_uri upon opening the popup ([#401](#401)) ([3be7506](3be7506)) * ADDON-62948 Added support for subTitle field in service ([#403](#403)) ([d1a5af1](d1a5af1)) * ADDON-64637 add input value to query for menu navigation ([3ca0c43](3ca0c43)) * bug fixes related to input and configuration page ([ca21343](ca21343)) * bugs ([56f5a79](56f5a79)) * bump version ([90719c4](90719c4)) * change in order of validations ([1d10657](1d10657)) * changed let to const to fix eslint error ([65ba327](65ba327)) * className missing in styled title and subtitle ([9328e85](9328e85)) * cleared fields for other authentication methods when using one ([deb2a54](deb2a54)) * **code:** ADDON-46211 Fiixed the issue to set the dynmic placeholder ([#117](#117)) ([37e5488](37e5488)) * **code:** ADDON-47626 Fixed the sorting issue for custom mapping ([#118](#118)) ([97b5cb2](97b5cb2)) * **CODE:** ADDON-47714 Fixed dependent field reset issue ([#120](#120)) ([51d9f58](51d9f58)) * **CODE:** ADDON-56621 Fixed the account/appliance with same name as tabs name conflict ([#121](#121)) ([ff1db3a](ff1db3a)) * **CODE:** ADDON-56881 Fixed the line breaker issue ([#134](#134)) ([28cff26](28cff26)) * **CODE:** ADDON-57152 Fixed tabs clicking issue when style is set to page ([#170](#170)) ([4974d59](4974d59)) * **CODE:** ADDON-57949 Fixed the custom menu with style property related issue ([#167](#167)) ([cecb3f1](cecb3f1)) * **CODE:** ADDON-58763 Fixed typo ([#179](#179)) ([1c74fae](1c74fae)) * **CODE:** ADDON-58867 Fixed cancelling selected dropdown value ([#188](#188)) ([0144432](0144432)) * custom cell/row should re-render when row is updated ([d285772](d285772)) * default to `basic` oauth_type if `undefined` to handle upgrade scenario for some add-ons ([db009eb](db009eb)) * dependabot alert for `postcss` ([b4126b7](b4126b7)) * dependabot reported security issues for `css-what` and `glob-parent` packages ([228b4c9](228b4c9)) * downgrade splunkui to 4.0.0 ([80ef18f](80ef18f)) * dynamically cleared out fields ([d12a970](d12a970)) * enforce logic for displaying clear button for singleselect when its disabled ([d430c85](d430c85)) * enhance toast message for `MODE_CONFIG`, surround entity names in double quotes and remove optional placeholder for oauth fields as its conflicting ([e5fe24d](e5fe24d)) * eslint and semgrep ([9b36bea](9b36bea)) * eslint failures ([b5edf0f](b5edf0f)) * fallback to latest form state if resthandler skips some table fields from response ([85a668c](85a668c)) * form submit should wait for state update from custom hook onSave ([9e19fa5](9e19fa5)) * formatted the code ([c736188](c736188)) * handle value `undefined` in table sort ([05b854a](05b854a)) * handled validation of optional fields in case of null value ([18d0c35](18d0c35)) * handled warnings and updated the changes ([c8240d5](c8240d5)) * Include license in pack ([0bcd002](0bcd002)) * include license with output ([5fbaf98](5fbaf98)) * keep only one way routing as done in ucc < 5 ([82b3aa7](82b3aa7)) * load dependent fields on form create ([b85516d](b85516d)) * missing files ([fc5a191](fc5a191)) * moved location of redirect_page.js ([86b44f5](86b44f5)) * overrun ([570b447](570b447)) * panels are required with at least 1 panel inside ([#382](#382)) ([eff3566](eff3566)) * parse boolean of `disabled` before setting it in state ([da76a93](da76a93)) * pass `count` query param in rest to overcome default thirty records limit ([245a3d8](245a3d8)) * pass empty string to i18n if the field is optional ([c045d18](c045d18)) * pass row and field to custom cell/row for processing on re-render ([f5a845e](f5a845e)) * precedence of autoCompleteFields vs. endpointUrl and label-value mapping for handling form save without click or enter event on combobox option ([0db4606](0db4606)) * precendence for multiselect items fetching ([02339bf](02339bf)) * priority for placeholder of optional fields ([405db62](405db62)) * remove extra rows which are empty in moreInfo ([5fbda62](5fbda62)) * remove redirect_url field from conf file ([9be7d81](9be7d81)) * remove unused code comments ([b4752d3](b4752d3)) * resolve missed `type` param for custom input row feature ([#84](#84)) ([fe17252](fe17252)) * revert "feat: ADDON-61556 Introduced checkbox group component ([#394](#394))" ([#428](#428)) ([358b1be](358b1be)) * revert 0497ac4e2e961ac141307a3ab7e6790e9bd31705 ([#309](#309)) ([e77242f](e77242f)) * **routing:** handle record param deletion on wrong tab and fix tab change due to missing dep in useCallback ([a9fe88b](a9fe88b)) * **schema.json:** add required configuration field ([#442](#442)) ([c3af60b](c3af60b)) * security warning for @npmcli/git ([e6847a6](e6847a6)) * singleSelect null value not being posted in form submit and add mapping support for heading in globalConfig ([94e11c3](94e11c3)) * skip `null` value fields from displaying in table expansion row ([7448eb8](7448eb8)) * **smartx:** add selectors for better testing ([ed2c153](ed2c153)) * toast notification not displaying when table is missing ([67b3f12](67b3f12)) * typo in comment for base form sumbitting ([d8634a1](d8634a1)) * UI breaking when globalConfig does not have inputs config ([7cf8708](7cf8708)) * update form hook onCreate error handling ([4a66418](4a66418)) * update license files ([09ac164](09ac164)) * update license in package ([0778aea](0778aea)) * update notice file ([79c5e74](79c5e74)) * update notice file ([a0b6d3f](a0b6d3f)) * update notice file ([d78e9a3](d78e9a3)) * update notice file ([840796a](840796a)) * Update NOTICE file ([#29](#29)) ([676d4c0](676d4c0)) * update react ui version to 4.0.0 ([78c4c10](78c4c10)) * update react-ui version, add class to title and subtitle components and update error message ([b79a6f5](b79a6f5)) * updated changes and added text with link support ([e14c940](e14c940)) * updated review changes ([85030c3](85030c3)) * updated review changes ([1ea41a6](1ea41a6)) * updated textbox width and changed field value for custom cell ([713954e](713954e)) * variable naming for status mapping ([74c7c6a](74c7c6a)) ### Features * add ComboBox and Select conditional rendering based on globalConfig options ([dbca65a](dbca65a)) * add DashboardPanel-s to dashboard ([#381](#381)) ([882f952](882f952)) * add label support for ([ccb1a4d](ccb1a4d)) * add meta.checkForUpdates field ([#433](#433)) ([5d92e96](5d92e96)) * add new default XML file without input ([#114](#114)) ([a359a0e](a359a0e)) * add support for globalConfig.yaml as well as JSON ([#116](#116)) ([725bc5c](725bc5c)) * add support of `required` param in oauth config ([f5bdce3](f5bdce3)) * add UI feature to enable/disable inputs in bulk ([#437](#437)) ([ab471d0](ab471d0)) * Added support of group fields ([b297deb](b297deb)) * **ADDON-37808:** enhance UX and UI for the error pages ([ec702f5](ec702f5)) * ADDON-57046: Added file input component ([#187](#187)) ([e0fb336](e0fb336)) * ADDON-57152 added tabs feature in the Inputs page ([#133](#133)) ([a3d9cb1](a3d9cb1)) * ADDON-61556 Introduced checkbox group component ([#394](#394)) ([9ffed80](9ffed80)) * ADDON-62948 Added support for subTitle field in service ([#402](#402)) ([6acd7cd](6acd7cd)) * ADDON-65006 add group name to URL when redirecting with Menu ([#429](#429)) ([9130b01](9130b01)) * allow esm JS modules as custom ui extensions to support external deps ([a2cc734](a2cc734)) * apiVersion is not required anymore ([6d4bf23](6d4bf23)) * **CODE:** ADDON-57044 Added new support for Textarea field ([#180](#180)) ([69a62b5](69a62b5)) * **CODE:** ADDON-58172 Version bump all the deps ([#175](#175)) ([50d98f8](50d98f8)) * **CODE:** ADDON-58506 Improve table using docked property ([#181](#181)) ([041452f](041452f)) * codeql ([729f42e](729f42e)) * Custom menu implementation ([58b0571](58b0571)) * First checking ([5648478](5648478)) * publish JS dependencies to appserver/package/static/js/dependencies.txt ([#103](#103)) ([3236b1b](3236b1b)) * release v1.19.0 ([#218](#218)) ([e23fbc6](e23fbc6)), closes [#201](#201) [#207](#207) [#208](#208) [#209](#209) [#210](#210) [#211](#211) [#212](#212) [#217](#217) * release v1.20.0 ([#236](#236)) ([996a463](996a463)), closes [#224](#224) [#225](#225) [#226](#226) * release v1.21.0 ([#271](https://github.com/splunk/addonfactory-ucc-generator/issues/271)) ([0e5df40](0e5df40)), closes [#238](#238) [#239](#239) [#240](#240) [#249](#249) [#250](#250) [#251](#251) [#252](#252) [#258](#258) * release v1.22.0 ([#293](#293)) ([9589e4a](9589e4a)), closes [#281](#281) [#282](#282) [#283](#283) [#291](#291) [#294](#294) * release v1.23.0 ([#306](#306)) ([7af8c06](7af8c06)), closes [#295](#295) [#297](#297) [#296](#296) [#305](#305) * release v1.24.0 ([#342](#342)) ([dff3799](dff3799)), closes [#328](#328) [#333](#333) * release v1.25.0 ([#362](#362)) ([305e13b](305e13b)), closes [#360](#360) [#361](#361) * Resolved comments ([6e7e424](6e7e424)) * Resolved review comments ([5998974](5998974)) * search internal logs button ([#371](#371)) ([439b0f6](439b0f6)) * support custom REST handlers ([#127](#127)) ([9b7ee29](9b7ee29)) * support placeholder entity type ([dd79c29](dd79c29)) * support placeholder in `globalConfig.json` for oauth fields ([8c90380](8c90380)) * trigger release (checkbox groups feature) ([#440](#440)) ([3c55957](3c55957)) * Updated dependencies ([ea02b95](ea02b95)) * use lazy loading for custom ui extensions ([7b3f349](7b3f349))
srv-rr-github-token
added a commit
that referenced
this pull request
Oct 5, 2023
# [5.31.0-beta.1](v5.30.0...v5.31.0-beta.1) (2023-10-05) ### Bug Fixes * Add ci ([#1](#1)) ([41c5a1a](41c5a1a)) * add classNames and data-test attributes to elements for SmartX ([254a1d1](254a1d1)) * add CSS id to button ([6859943](6859943)) * add data-name attribute in ControlGroup for ease in writing automated UI tests ([10da489](10da489)) * add data-test-loading for Select ([42a165d](42a165d)) * add ids to tab container in configuration page ([2a29d2f](2a29d2f)) * add notice in release tarball ([a4590e5](a4590e5)) * add schema.json in release tarball ([c474e7b](c474e7b)) * added comment ([f96adf1](f96adf1)) * added help text link support ([6c94df9](6c94df9)) * ADDON-61204 Remove support of placeholder property ([2677cf9](2677cf9)) * ADDON-61381 Fixed the design issue in Safari browser ([#386](#386)) ([b6a7195](b6a7195)) * ADDON-62193 encoded the redirect_uri upon opening the popup ([#401](#401)) ([3be7506](3be7506)) * ADDON-62948 Added support for subTitle field in service ([#403](#403)) ([d1a5af1](d1a5af1)) * ADDON-64637 add input value to query for menu navigation ([3ca0c43](3ca0c43)) * bug fixes related to input and configuration page ([ca21343](ca21343)) * bugs ([56f5a79](56f5a79)) * bump version ([90719c4](90719c4)) * change in order of validations ([1d10657](1d10657)) * changed let to const to fix eslint error ([65ba327](65ba327)) * className missing in styled title and subtitle ([9328e85](9328e85)) * cleared fields for other authentication methods when using one ([deb2a54](deb2a54)) * **code:** ADDON-46211 Fiixed the issue to set the dynmic placeholder ([#117](#117)) ([37e5488](37e5488)) * **code:** ADDON-47626 Fixed the sorting issue for custom mapping ([#118](#118)) ([97b5cb2](97b5cb2)) * **CODE:** ADDON-47714 Fixed dependent field reset issue ([#120](#120)) ([51d9f58](51d9f58)) * **CODE:** ADDON-56621 Fixed the account/appliance with same name as tabs name conflict ([#121](#121)) ([ff1db3a](ff1db3a)) * **CODE:** ADDON-56881 Fixed the line breaker issue ([#134](#134)) ([28cff26](28cff26)) * **CODE:** ADDON-57152 Fixed tabs clicking issue when style is set to page ([#170](#170)) ([4974d59](4974d59)) * **CODE:** ADDON-57949 Fixed the custom menu with style property related issue ([#167](#167)) ([cecb3f1](cecb3f1)) * **CODE:** ADDON-58763 Fixed typo ([#179](#179)) ([1c74fae](1c74fae)) * **CODE:** ADDON-58867 Fixed cancelling selected dropdown value ([#188](#188)) ([0144432](0144432)) * custom cell/row should re-render when row is updated ([d285772](d285772)) * default to `basic` oauth_type if `undefined` to handle upgrade scenario for some add-ons ([db009eb](db009eb)) * dependabot alert for `postcss` ([b4126b7](b4126b7)) * dependabot reported security issues for `css-what` and `glob-parent` packages ([228b4c9](228b4c9)) * downgrade splunkui to 4.0.0 ([80ef18f](80ef18f)) * dynamically cleared out fields ([d12a970](d12a970)) * enforce logic for displaying clear button for singleselect when its disabled ([d430c85](d430c85)) * enhance toast message for `MODE_CONFIG`, surround entity names in double quotes and remove optional placeholder for oauth fields as its conflicting ([e5fe24d](e5fe24d)) * eslint and semgrep ([9b36bea](9b36bea)) * eslint failures ([b5edf0f](b5edf0f)) * fallback to latest form state if resthandler skips some table fields from response ([85a668c](85a668c)) * form submit should wait for state update from custom hook onSave ([9e19fa5](9e19fa5)) * formatted the code ([c736188](c736188)) * handle value `undefined` in table sort ([05b854a](05b854a)) * handled validation of optional fields in case of null value ([18d0c35](18d0c35)) * handled warnings and updated the changes ([c8240d5](c8240d5)) * Include license in pack ([0bcd002](0bcd002)) * include license with output ([5fbaf98](5fbaf98)) * keep only one way routing as done in ucc < 5 ([82b3aa7](82b3aa7)) * load dependent fields on form create ([b85516d](b85516d)) * missing files ([fc5a191](fc5a191)) * moved location of redirect_page.js ([86b44f5](86b44f5)) * overrun ([570b447](570b447)) * panels are required with at least 1 panel inside ([#382](#382)) ([eff3566](eff3566)) * parse boolean of `disabled` before setting it in state ([da76a93](da76a93)) * pass `count` query param in rest to overcome default thirty records limit ([245a3d8](245a3d8)) * pass empty string to i18n if the field is optional ([c045d18](c045d18)) * pass row and field to custom cell/row for processing on re-render ([f5a845e](f5a845e)) * precedence of autoCompleteFields vs. endpointUrl and label-value mapping for handling form save without click or enter event on combobox option ([0db4606](0db4606)) * precendence for multiselect items fetching ([02339bf](02339bf)) * priority for placeholder of optional fields ([405db62](405db62)) * remove extra rows which are empty in moreInfo ([5fbda62](5fbda62)) * remove redirect_url field from conf file ([9be7d81](9be7d81)) * remove unused code comments ([b4752d3](b4752d3)) * resolve missed `type` param for custom input row feature ([#84](#84)) ([fe17252](fe17252)) * revert "feat: ADDON-61556 Introduced checkbox group component ([#394](#394))" ([#428](#428)) ([358b1be](358b1be)) * revert 0497ac4e2e961ac141307a3ab7e6790e9bd31705 ([#309](#309)) ([e77242f](e77242f)) * **routing:** handle record param deletion on wrong tab and fix tab change due to missing dep in useCallback ([a9fe88b](a9fe88b)) * **schema.json:** add required configuration field ([#442](#442)) ([c3af60b](c3af60b)) * security warning for @npmcli/git ([e6847a6](e6847a6)) * singleSelect null value not being posted in form submit and add mapping support for heading in globalConfig ([94e11c3](94e11c3)) * skip `null` value fields from displaying in table expansion row ([7448eb8](7448eb8)) * **smartx:** add selectors for better testing ([ed2c153](ed2c153)) * toast notification not displaying when table is missing ([67b3f12](67b3f12)) * typo in comment for base form sumbitting ([d8634a1](d8634a1)) * UI breaking when globalConfig does not have inputs config ([7cf8708](7cf8708)) * update form hook onCreate error handling ([4a66418](4a66418)) * update license files ([09ac164](09ac164)) * update license in package ([0778aea](0778aea)) * update notice file ([79c5e74](79c5e74)) * update notice file ([a0b6d3f](a0b6d3f)) * update notice file ([d78e9a3](d78e9a3)) * update notice file ([840796a](840796a)) * Update NOTICE file ([#29](#29)) ([676d4c0](676d4c0)) * update react ui version to 4.0.0 ([78c4c10](78c4c10)) * update react-ui version, add class to title and subtitle components and update error message ([b79a6f5](b79a6f5)) * updated changes and added text with link support ([e14c940](e14c940)) * updated review changes ([85030c3](85030c3)) * updated review changes ([1ea41a6](1ea41a6)) * updated textbox width and changed field value for custom cell ([713954e](713954e)) * variable naming for status mapping ([74c7c6a](74c7c6a)) ### Features * add ComboBox and Select conditional rendering based on globalConfig options ([dbca65a](dbca65a)) * add DashboardPanel-s to dashboard ([#381](#381)) ([882f952](882f952)) * add label support for ([ccb1a4d](ccb1a4d)) * add meta.checkForUpdates field ([#433](#433)) ([5d92e96](5d92e96)) * add new default XML file without input ([#114](#114)) ([a359a0e](a359a0e)) * add support for globalConfig.yaml as well as JSON ([#116](#116)) ([725bc5c](725bc5c)) * add support of `required` param in oauth config ([f5bdce3](f5bdce3)) * add UI feature to enable/disable inputs in bulk ([#437](#437)) ([ab471d0](ab471d0)) * Added support of group fields ([b297deb](b297deb)) * **ADDON-37808:** enhance UX and UI for the error pages ([ec702f5](ec702f5)) * ADDON-57046: Added file input component ([#187](#187)) ([e0fb336](e0fb336)) * ADDON-57152 added tabs feature in the Inputs page ([#133](#133)) ([a3d9cb1](a3d9cb1)) * ADDON-61556 Introduced checkbox group component ([#394](#394)) ([9ffed80](9ffed80)) * ADDON-62948 Added support for subTitle field in service ([#402](#402)) ([6acd7cd](6acd7cd)) * ADDON-65006 add group name to URL when redirecting with Menu ([#429](#429)) ([9130b01](9130b01)) * allow esm JS modules as custom ui extensions to support external deps ([a2cc734](a2cc734)) * apiVersion is not required anymore ([6d4bf23](6d4bf23)) * **CODE:** ADDON-57044 Added new support for Textarea field ([#180](#180)) ([69a62b5](69a62b5)) * **CODE:** ADDON-58172 Version bump all the deps ([#175](#175)) ([50d98f8](50d98f8)) * **CODE:** ADDON-58506 Improve table using docked property ([#181](#181)) ([041452f](041452f)) * codeql ([729f42e](729f42e)) * Custom menu implementation ([58b0571](58b0571)) * First checking ([5648478](5648478)) * publish JS dependencies to appserver/package/static/js/dependencies.txt ([#103](#103)) ([3236b1b](3236b1b)) * release v1.19.0 ([#218](#218)) ([e23fbc6](e23fbc6)), closes [#201](#201) [#207](#207) [#208](#208) [#209](#209) [#210](#210) [#211](#211) [#212](#212) [#217](#217) * release v1.20.0 ([#236](#236)) ([996a463](996a463)), closes [#224](#224) [#225](#225) [#226](#226) * release v1.21.0 ([#271](https://github.com/splunk/addonfactory-ucc-generator/issues/271)) ([0e5df40](0e5df40)), closes [#238](#238) [#239](#239) [#240](#240) [#249](#249) [#250](#250) [#251](#251) [#252](#252) [#258](#258) * release v1.22.0 ([#293](#293)) ([9589e4a](9589e4a)), closes [#281](#281) [#282](#282) [#283](#283) [#291](#291) [#294](#294) * release v1.23.0 ([#306](#306)) ([7af8c06](7af8c06)), closes [#295](#295) [#297](#297) [#296](#296) [#305](#305) * release v1.24.0 ([#342](#342)) ([dff3799](dff3799)), closes [#328](#328) [#333](#333) * release v1.25.0 ([#362](#362)) ([305e13b](305e13b)), closes [#360](#360) [#361](#361) * Resolved comments ([6e7e424](6e7e424)) * Resolved review comments ([5998974](5998974)) * search internal logs button ([#371](#371)) ([439b0f6](439b0f6)) * support custom REST handlers ([#127](#127)) ([9b7ee29](9b7ee29)) * support placeholder entity type ([dd79c29](dd79c29)) * support placeholder in `globalConfig.json` for oauth fields ([8c90380](8c90380)) * trigger release (checkbox groups feature) ([#440](#440)) ([3c55957](3c55957)) * Updated dependencies ([ea02b95](ea02b95)) * use lazy loading for custom ui extensions ([7b3f349](7b3f349))
srv-rr-github-token
added a commit
that referenced
this pull request
Oct 5, 2023
# [5.31.0](v5.30.0...v5.31.0) (2023-10-05) ### Bug Fixes * Add ci ([#1](#1)) ([41c5a1a](41c5a1a)) * add classNames and data-test attributes to elements for SmartX ([254a1d1](254a1d1)) * add CSS id to button ([6859943](6859943)) * add data-name attribute in ControlGroup for ease in writing automated UI tests ([10da489](10da489)) * add data-test-loading for Select ([42a165d](42a165d)) * add ids to tab container in configuration page ([2a29d2f](2a29d2f)) * add notice in release tarball ([a4590e5](a4590e5)) * add schema.json in release tarball ([c474e7b](c474e7b)) * added comment ([f96adf1](f96adf1)) * added help text link support ([6c94df9](6c94df9)) * ADDON-61204 Remove support of placeholder property ([2677cf9](2677cf9)) * ADDON-61381 Fixed the design issue in Safari browser ([#386](#386)) ([b6a7195](b6a7195)) * ADDON-62193 encoded the redirect_uri upon opening the popup ([#401](#401)) ([3be7506](3be7506)) * ADDON-62948 Added support for subTitle field in service ([#403](#403)) ([d1a5af1](d1a5af1)) * ADDON-64637 add input value to query for menu navigation ([3ca0c43](3ca0c43)) * bug fixes related to input and configuration page ([ca21343](ca21343)) * bugs ([56f5a79](56f5a79)) * bump version ([90719c4](90719c4)) * change in order of validations ([1d10657](1d10657)) * changed let to const to fix eslint error ([65ba327](65ba327)) * className missing in styled title and subtitle ([9328e85](9328e85)) * cleared fields for other authentication methods when using one ([deb2a54](deb2a54)) * **code:** ADDON-46211 Fiixed the issue to set the dynmic placeholder ([#117](#117)) ([37e5488](37e5488)) * **code:** ADDON-47626 Fixed the sorting issue for custom mapping ([#118](#118)) ([97b5cb2](97b5cb2)) * **CODE:** ADDON-47714 Fixed dependent field reset issue ([#120](#120)) ([51d9f58](51d9f58)) * **CODE:** ADDON-56621 Fixed the account/appliance with same name as tabs name conflict ([#121](#121)) ([ff1db3a](ff1db3a)) * **CODE:** ADDON-56881 Fixed the line breaker issue ([#134](#134)) ([28cff26](28cff26)) * **CODE:** ADDON-57152 Fixed tabs clicking issue when style is set to page ([#170](#170)) ([4974d59](4974d59)) * **CODE:** ADDON-57949 Fixed the custom menu with style property related issue ([#167](#167)) ([cecb3f1](cecb3f1)) * **CODE:** ADDON-58763 Fixed typo ([#179](#179)) ([1c74fae](1c74fae)) * **CODE:** ADDON-58867 Fixed cancelling selected dropdown value ([#188](#188)) ([0144432](0144432)) * custom cell/row should re-render when row is updated ([d285772](d285772)) * default to `basic` oauth_type if `undefined` to handle upgrade scenario for some add-ons ([db009eb](db009eb)) * dependabot alert for `postcss` ([b4126b7](b4126b7)) * dependabot reported security issues for `css-what` and `glob-parent` packages ([228b4c9](228b4c9)) * downgrade splunkui to 4.0.0 ([80ef18f](80ef18f)) * dynamically cleared out fields ([d12a970](d12a970)) * enforce logic for displaying clear button for singleselect when its disabled ([d430c85](d430c85)) * enhance toast message for `MODE_CONFIG`, surround entity names in double quotes and remove optional placeholder for oauth fields as its conflicting ([e5fe24d](e5fe24d)) * eslint and semgrep ([9b36bea](9b36bea)) * eslint failures ([b5edf0f](b5edf0f)) * fallback to latest form state if resthandler skips some table fields from response ([85a668c](85a668c)) * form submit should wait for state update from custom hook onSave ([9e19fa5](9e19fa5)) * formatted the code ([c736188](c736188)) * handle value `undefined` in table sort ([05b854a](05b854a)) * handled validation of optional fields in case of null value ([18d0c35](18d0c35)) * handled warnings and updated the changes ([c8240d5](c8240d5)) * Include license in pack ([0bcd002](0bcd002)) * include license with output ([5fbaf98](5fbaf98)) * keep only one way routing as done in ucc < 5 ([82b3aa7](82b3aa7)) * load dependent fields on form create ([b85516d](b85516d)) * missing files ([fc5a191](fc5a191)) * moved location of redirect_page.js ([86b44f5](86b44f5)) * overrun ([570b447](570b447)) * panels are required with at least 1 panel inside ([#382](#382)) ([eff3566](eff3566)) * parse boolean of `disabled` before setting it in state ([da76a93](da76a93)) * pass `count` query param in rest to overcome default thirty records limit ([245a3d8](245a3d8)) * pass empty string to i18n if the field is optional ([c045d18](c045d18)) * pass row and field to custom cell/row for processing on re-render ([f5a845e](f5a845e)) * precedence of autoCompleteFields vs. endpointUrl and label-value mapping for handling form save without click or enter event on combobox option ([0db4606](0db4606)) * precendence for multiselect items fetching ([02339bf](02339bf)) * priority for placeholder of optional fields ([405db62](405db62)) * remove extra rows which are empty in moreInfo ([5fbda62](5fbda62)) * remove redirect_url field from conf file ([9be7d81](9be7d81)) * remove unused code comments ([b4752d3](b4752d3)) * resolve missed `type` param for custom input row feature ([#84](#84)) ([fe17252](fe17252)) * revert "feat: ADDON-61556 Introduced checkbox group component ([#394](#394))" ([#428](#428)) ([358b1be](358b1be)) * revert 0497ac4e2e961ac141307a3ab7e6790e9bd31705 ([#309](#309)) ([e77242f](e77242f)) * **routing:** handle record param deletion on wrong tab and fix tab change due to missing dep in useCallback ([a9fe88b](a9fe88b)) * **schema.json:** add required configuration field ([#442](#442)) ([c3af60b](c3af60b)) * security warning for @npmcli/git ([e6847a6](e6847a6)) * singleSelect null value not being posted in form submit and add mapping support for heading in globalConfig ([94e11c3](94e11c3)) * skip `null` value fields from displaying in table expansion row ([7448eb8](7448eb8)) * **smartx:** add selectors for better testing ([ed2c153](ed2c153)) * toast notification not displaying when table is missing ([67b3f12](67b3f12)) * typo in comment for base form sumbitting ([d8634a1](d8634a1)) * UI breaking when globalConfig does not have inputs config ([7cf8708](7cf8708)) * update form hook onCreate error handling ([4a66418](4a66418)) * update license files ([09ac164](09ac164)) * update license in package ([0778aea](0778aea)) * update notice file ([79c5e74](79c5e74)) * update notice file ([a0b6d3f](a0b6d3f)) * update notice file ([d78e9a3](d78e9a3)) * update notice file ([840796a](840796a)) * Update NOTICE file ([#29](#29)) ([676d4c0](676d4c0)) * update react ui version to 4.0.0 ([78c4c10](78c4c10)) * update react-ui version, add class to title and subtitle components and update error message ([b79a6f5](b79a6f5)) * updated changes and added text with link support ([e14c940](e14c940)) * updated review changes ([85030c3](85030c3)) * updated review changes ([1ea41a6](1ea41a6)) * updated textbox width and changed field value for custom cell ([713954e](713954e)) * variable naming for status mapping ([74c7c6a](74c7c6a)) ### Features * add ComboBox and Select conditional rendering based on globalConfig options ([dbca65a](dbca65a)) * add DashboardPanel-s to dashboard ([#381](#381)) ([882f952](882f952)) * add label support for ([ccb1a4d](ccb1a4d)) * add meta.checkForUpdates field ([#433](#433)) ([5d92e96](5d92e96)) * add new default XML file without input ([#114](#114)) ([a359a0e](a359a0e)) * add support for globalConfig.yaml as well as JSON ([#116](#116)) ([725bc5c](725bc5c)) * add support of `required` param in oauth config ([f5bdce3](f5bdce3)) * add UI feature to enable/disable inputs in bulk ([#437](#437)) ([ab471d0](ab471d0)) * Added support of group fields ([b297deb](b297deb)) * **ADDON-37808:** enhance UX and UI for the error pages ([ec702f5](ec702f5)) * ADDON-57046: Added file input component ([#187](#187)) ([e0fb336](e0fb336)) * ADDON-57152 added tabs feature in the Inputs page ([#133](#133)) ([a3d9cb1](a3d9cb1)) * ADDON-61556 Introduced checkbox group component ([#394](#394)) ([9ffed80](9ffed80)) * ADDON-62948 Added support for subTitle field in service ([#402](#402)) ([6acd7cd](6acd7cd)) * ADDON-65006 add group name to URL when redirecting with Menu ([#429](#429)) ([9130b01](9130b01)) * allow esm JS modules as custom ui extensions to support external deps ([a2cc734](a2cc734)) * apiVersion is not required anymore ([6d4bf23](6d4bf23)) * **CODE:** ADDON-57044 Added new support for Textarea field ([#180](#180)) ([69a62b5](69a62b5)) * **CODE:** ADDON-58172 Version bump all the deps ([#175](#175)) ([50d98f8](50d98f8)) * **CODE:** ADDON-58506 Improve table using docked property ([#181](#181)) ([041452f](041452f)) * codeql ([729f42e](729f42e)) * Custom menu implementation ([58b0571](58b0571)) * First checking ([5648478](5648478)) * publish JS dependencies to appserver/package/static/js/dependencies.txt ([#103](#103)) ([3236b1b](3236b1b)) * release v1.19.0 ([#218](#218)) ([e23fbc6](e23fbc6)), closes [#201](#201) [#207](#207) [#208](#208) [#209](#209) [#210](#210) [#211](#211) [#212](#212) [#217](#217) * release v1.20.0 ([#236](#236)) ([996a463](996a463)), closes [#224](#224) [#225](#225) [#226](#226) * release v1.21.0 ([#271](https://github.com/splunk/addonfactory-ucc-generator/issues/271)) ([0e5df40](0e5df40)), closes [#238](#238) [#239](#239) [#240](#240) [#249](#249) [#250](#250) [#251](#251) [#252](#252) [#258](#258) * release v1.22.0 ([#293](#293)) ([9589e4a](9589e4a)), closes [#281](#281) [#282](#282) [#283](#283) [#291](#291) [#294](#294) * release v1.23.0 ([#306](#306)) ([7af8c06](7af8c06)), closes [#295](#295) [#297](#297) [#296](#296) [#305](#305) * release v1.24.0 ([#342](#342)) ([dff3799](dff3799)), closes [#328](#328) [#333](#333) * release v1.25.0 ([#362](#362)) ([305e13b](305e13b)), closes [#360](#360) [#361](#361) * Resolved comments ([6e7e424](6e7e424)) * Resolved review comments ([5998974](5998974)) * search internal logs button ([#371](#371)) ([439b0f6](439b0f6)) * support custom REST handlers ([#127](#127)) ([9b7ee29](9b7ee29)) * support placeholder entity type ([dd79c29](dd79c29)) * support placeholder in `globalConfig.json` for oauth fields ([8c90380](8c90380)) * trigger release (checkbox groups feature) ([#440](#440)) ([3c55957](3c55957)) * Updated dependencies ([ea02b95](ea02b95)) * use lazy loading for custom ui extensions ([7b3f349](7b3f349))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.